Skip to content

Commit 37a41be

Browse files
committed
Address comment: Add new test to bit-utility-test instead of utility-test, and move bitmap tests from bit_util_test.cc into the new file
1 parent a2bb31d commit 37a41be

File tree

5 files changed

+1460
-1442
lines changed

5 files changed

+1460
-1442
lines changed

cpp/src/arrow/util/CMakeLists.txt

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,6 @@ add_arrow_test(utility-test
4949
SOURCES
5050
align_util_test.cc
5151
atfork_test.cc
52-
bitmap_test.cc
5352
byte_size_test.cc
5453
byte_stream_split_test.cc
5554
cache_test.cc
@@ -99,8 +98,16 @@ add_arrow_test(bit-utility-test
9998
SOURCES
10099
bit_block_counter_test.cc
101100
bit_util_test.cc
101+
bitmap_test.cc
102102
bpacking_test.cc
103-
rle_encoding_test.cc)
103+
rle_encoding_test.cc
104+
test_common.cc)
105+
106+
add_arrow_test(crc32-test
107+
SOURCES
108+
crc32_test.cc
109+
EXTRA_LINK_LIBS
110+
Boost::headers)
104111

105112
add_arrow_test(threading-utility-test
106113
SOURCES
@@ -111,16 +118,10 @@ add_arrow_test(threading-utility-test
111118
test_common.cc
112119
thread_pool_test.cc)
113120

114-
add_arrow_test(crc32-test
115-
SOURCES
116-
crc32_test.cc
117-
EXTRA_LINK_LIBS
118-
Boost::headers)
119-
120121
add_arrow_benchmark(bit_block_counter_benchmark)
121122
add_arrow_benchmark(bit_util_benchmark)
122-
add_arrow_benchmark(bpacking_benchmark)
123123
add_arrow_benchmark(bitmap_reader_benchmark)
124+
add_arrow_benchmark(bpacking_benchmark)
124125
add_arrow_benchmark(cache_benchmark)
125126
add_arrow_benchmark(compression_benchmark)
126127
add_arrow_benchmark(decimal_benchmark)

0 commit comments

Comments
 (0)