GH-45885: [C++] Require C++20

Author: pitrou

.github/workflows/cpp_windows.yml

@@ -63,7 +63,7 @@ jobs:
       ARROW_WITH_ZLIB: ON
       ARROW_WITH_ZSTD: ON
       BOOST_SOURCE: BUNDLED
-      CMAKE_CXX_STANDARD: "17"
+      CMAKE_CXX_STANDARD: "20"
       CMAKE_GENERATOR: Ninja
       CMAKE_INSTALL_PREFIX: /usr
       CMAKE_UNITY_BUILD: ON

.github/workflows/r.yml

@@ -229,12 +229,13 @@ jobs:
           # static library. The R is not used here but R 4.1 was the last R to use
           # Rtools40.
           r-version: "4.1"
-          rtools-version: 40
+          rtools-version: ${{ matrix.config.rtools }}
           Ncpus: 2
       - name: Build Arrow C++
         shell: bash
         env:
           MINGW_ARCH: ${{ matrix.config.arch }}
+          RTOOLS_VERSION: ${{ matrix.config.rtools }}
         run: ci/scripts/r_windows_build.sh
       - name: Rename libarrow.zip
         # So that they're unique when multiple are downloaded in the next step

.github/workflows/ruby.yml

@@ -349,7 +349,7 @@ jobs:
       ARROW_WITH_SNAPPY: ON
       ARROW_WITH_ZLIB: ON
       ARROW_WITH_ZSTD: ON
-      CMAKE_CXX_STANDARD: "17"
+      CMAKE_CXX_STANDARD: "20"
       CMAKE_GENERATOR: Ninja
       CMAKE_INSTALL_PREFIX: "${{ github.workspace }}/dist"
       VCPKG_BINARY_SOURCES: 'clear;nuget,GitHub,readwrite'

c_glib/meson.build

@@ -21,7 +21,7 @@ project(
     'arrow-glib',
     'c',
     'cpp',
-    default_options: ['c_std=c99', 'cpp_std=c++17'],
+    default_options: ['c_std=c99', 'cpp_std=c++20'],
     license: 'Apache-2.0',
     # Debian:
     #   https://packages.debian.org/search?keywords=meson

ci/docker/centos-7-cpp.dockerfile

@@ -25,7 +25,7 @@ RUN sed -i \
       -e 's/mirror\.centos\.org/vault.centos.org/' \
       /etc/yum.repos.d/*.repo
 
-# devtoolset is required for C++17
+# devtoolset is required for C++20
 RUN \
   yum install -y \
     centos-release-scl \
@@ -38,7 +38,8 @@ RUN \
     /etc/yum.repos.d/CentOS-SCLo-scl*.repo && \
   yum install -y \
     curl \
-    devtoolset-8 \
+    devtoolset-11-gcc-c++ \
+    devtoolset-11-make \
     diffutils \
     gcc-c++ \
     libcurl-devel \

ci/scripts/cpp_build.sh

@@ -168,7 +168,7 @@ elif [ "${ARROW_EMSCRIPTEN:-OFF}" = "ON" ]; then
     -DCMAKE_VERBOSE_MAKEFILE=${CMAKE_VERBOSE_MAKEFILE:-OFF} \
     -DCMAKE_C_FLAGS="${CFLAGS:-}" \
     -DCMAKE_CXX_FLAGS="${CXXFLAGS:-}" \
-    -DCMAKE_CXX_STANDARD="${CMAKE_CXX_STANDARD:-17}" \
+    -DCMAKE_CXX_STANDARD="${CMAKE_CXX_STANDARD:-20}" \
     -DCMAKE_INSTALL_LIBDIR=${CMAKE_INSTALL_LIBDIR:-lib} \
     -DCMAKE_INSTALL_PREFIX=${CMAKE_INSTALL_PREFIX:-${ARROW_HOME}} \
     -DCMAKE_UNITY_BUILD=${CMAKE_UNITY_BUILD:-OFF} \
@@ -260,7 +260,7 @@ else
     -DCMAKE_VERBOSE_MAKEFILE=${CMAKE_VERBOSE_MAKEFILE:-OFF} \
     -DCMAKE_C_FLAGS="${CFLAGS:-}" \
     -DCMAKE_CXX_FLAGS="${CXXFLAGS:-}" \
-    -DCMAKE_CXX_STANDARD="${CMAKE_CXX_STANDARD:-17}" \
+    -DCMAKE_CXX_STANDARD="${CMAKE_CXX_STANDARD:-20}" \
     -DCMAKE_INSTALL_LIBDIR=${CMAKE_INSTALL_LIBDIR:-lib} \
     -DCMAKE_INSTALL_PREFIX=${CMAKE_INSTALL_PREFIX:-${ARROW_HOME}} \
     -DCMAKE_UNITY_BUILD=${CMAKE_UNITY_BUILD:-OFF} \

ci/scripts/r_windows_build.sh

@@ -44,7 +44,7 @@ mv mingw* build
 cd build
 
 # This may vary by system/CI provider
-MSYS_LIB_DIR="/c/rtools40"
+MSYS_LIB_DIR="/c/rtools${RTOOLS_VERSION}"
 
 # Untar the builds we made
 ls *.xz | xargs -n 1 tar -xJf

compose.yaml

@@ -465,7 +465,7 @@ services:
       ARROW_HOME: /arrow
       LIBARROW_MINIMAL: "false"
     command: /bin/bash -c "
-          scl enable devtoolset-8 '/arrow/r/inst/build_arrow_static.sh'"
+          scl enable devtoolset-11 '/arrow/r/inst/build_arrow_static.sh'"
 
   ubuntu-cpp-bundled:
     # Arrow build with BUNDLED dependencies

cpp/CMakeLists.txt

@@ -530,10 +530,10 @@ set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${ARROW_CXXFLAGS}")
 # C++ specific flags.
 set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} ${CXX_COMMON_FLAGS} ${ARROW_CXXFLAGS}")
 
-# Remove --std=c++17 to avoid errors from C compilers
-string(REPLACE "-std=c++17" "" CMAKE_C_FLAGS ${CMAKE_C_FLAGS})
+# Remove -std=c++20 to avoid errors from C compilers
+string(REPLACE "-std=c++20" "" CMAKE_C_FLAGS ${CMAKE_C_FLAGS})
 
-# Add C++-only flags, like -std=c++17
+# Add C++-only flags, like -std=c++20
 set(CMAKE_CXX_FLAGS "${CXX_ONLY_FLAGS} ${CMAKE_CXX_FLAGS}")
 
 # ASAN / TSAN / UBSAN

cpp/cmake_modules/GandivaAddBitcode.cmake

@@ -17,7 +17,7 @@
 
 # Create bitcode for the given source file.
 function(gandiva_add_bitcode SOURCE)
-  set(CLANG_OPTIONS -std=c++17)
+  set(CLANG_OPTIONS -std=c++20)
   if(MSVC)
     # "19.20" means that it's compatible with Visual Studio 16 2019.
     # We can update this to "19.30" when we dropped support for Visual