Removed unnecessary StartsWith, EndsWith utility functions

Author: Jonahkel

cpp/src/arrow/engine/simple_extension_type_internal.h

@@ -111,7 +111,7 @@ class SimpleExtensionType : public ExtensionType {
     void Fail() { params_ = std::nullopt; }
 
     void Init(std::string_view class_name, std::string_view repr, size_t num_properties) {
-      if (!::arrow::internal::StartsWith(repr, class_name)) return Fail();
+      if (!repr.starts_with(class_name)) return Fail();
 
       repr = repr.substr(class_name.size());
       if (repr.empty()) return Fail();

cpp/src/arrow/util/string.h

@@ -52,16 +52,6 @@ ARROW_EXPORT Status ParseHexValues(std::string_view hex_string, uint8_t* out);
 
 namespace internal {
 
-/// Like std::string_view::starts_with in C++20
-inline bool StartsWith(std::string_view s, std::string_view prefix) {
-  return s.starts_with(prefix);
-}
-
-/// Like std::string_view::ends_with in C++20
-inline bool EndsWith(std::string_view s, std::string_view suffix) {
-  return s.ends_with(suffix);
-}
-
 /// \brief Split a string with a delimiter
 ARROW_EXPORT
 std::vector<std::string_view> SplitString(std::string_view v, char delim,

cpp/src/arrow/util/string_test.cc

@@ -170,34 +170,6 @@ TEST(SplitString, LimitZero) {
   EXPECT_EQ(parts[2], "c");
 }
 
-TEST(StartsWith, Basics) {
-  std::string empty{};
-  std::string abc{"abc"};
-  std::string abcdef{"abcdef"};
-  std::string def{"def"};
-  ASSERT_TRUE(StartsWith(empty, empty));
-  ASSERT_TRUE(StartsWith(abc, empty));
-  ASSERT_TRUE(StartsWith(abc, abc));
-  ASSERT_TRUE(StartsWith(abcdef, abc));
-  ASSERT_FALSE(StartsWith(abc, abcdef));
-  ASSERT_FALSE(StartsWith(def, abcdef));
-  ASSERT_FALSE(StartsWith(abcdef, def));
-}
-
-TEST(EndsWith, Basics) {
-  std::string empty{};
-  std::string abc{"abc"};
-  std::string abcdef{"abcdef"};
-  std::string def{"def"};
-  ASSERT_TRUE(EndsWith(empty, empty));
-  ASSERT_TRUE(EndsWith(abc, empty));
-  ASSERT_TRUE(EndsWith(abc, abc));
-  ASSERT_TRUE(EndsWith(abcdef, def));
-  ASSERT_FALSE(EndsWith(abcdef, abc));
-  ASSERT_FALSE(EndsWith(def, abcdef));
-  ASSERT_FALSE(EndsWith(abcdef, abc));
-}
-
 TEST(RegexMatch, Basics) {
   std::regex regex("a+(b*)(c+)d+");
   std::string_view b, c;

cpp/src/parquet/arrow/schema.cc

@@ -49,7 +49,6 @@ using arrow::FieldVector;
 using arrow::KeyValueMetadata;
 using arrow::Status;
 using arrow::internal::checked_cast;
-using arrow::internal::EndsWith;
 using arrow::internal::ToChars;
 
 using ArrowType = arrow::DataType;