Skip to content

Commit 501eab7

Browse files
committed
Fix SQLStmtAttr tests
1 parent 1e5ee78 commit 501eab7

File tree

2 files changed

+5
-6
lines changed

2 files changed

+5
-6
lines changed

cpp/src/arrow/flight/sql/odbc/tests/odbc_test_suite.cc

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -61,13 +61,11 @@ void ODBCRemoteTestBase::ConnectWithString(std::string connect_str) {
6161
kOdbcBufferSize, &out_str_len, SQL_DRIVER_NOPROMPT))
6262
<< GetOdbcErrorMessage(SQL_HANDLE_DBC, conn);
6363

64-
// GH-47710: TODO Allocate a statement using alloc handle
65-
// ASSERT_EQ(SQL_SUCCESS, SQLAllocHandle(SQL_HANDLE_STMT, conn, &stmt));
64+
ASSERT_EQ(SQL_SUCCESS, SQLAllocHandle(SQL_HANDLE_STMT, conn, &stmt));
6665
}
6766

6867
void ODBCRemoteTestBase::Disconnect() {
69-
// GH-47710: TODO Close statement
70-
// EXPECT_EQ(SQL_SUCCESS, SQLFreeHandle(SQL_HANDLE_STMT, stmt));
68+
EXPECT_EQ(SQL_SUCCESS, SQLFreeHandle(SQL_HANDLE_STMT, stmt));
7169

7270
// Disconnect from ODBC
7371
EXPECT_EQ(SQL_SUCCESS, SQLDisconnect(conn))

cpp/src/arrow/flight/sql/odbc/tests/statement_attr_test.cc

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -325,7 +325,8 @@ TYPED_TEST(StatementAttributeTest, TestSQLGetStmtAttrRowBindType) {
325325
EXPECT_EQ(static_cast<SQLULEN>(0), value);
326326
}
327327

328-
TYPED_TEST(StatementAttributeTest, TestSQLGetStmtAttrRowNumber) {
328+
TYPED_TEST(StatementAttributeTest, DISABLED_TestSQLGetStmtAttrRowNumber) {
329+
// GH-47711 TODO: enable test after SQLExecDirect support
329330
std::wstring wsql = L"SELECT 1;";
330331
std::vector<SQLWCHAR> sql0(wsql.begin(), wsql.end());
331332

@@ -616,7 +617,7 @@ TYPED_TEST(StatementAttributeTest, TestSQLSetStmtAttrRowOperationPtr) {
616617

617618
TYPED_TEST(StatementAttributeTest, TestSQLSetStmtAttrRowStatusPtr) {
618619
constexpr SQLULEN row_status_size = 4;
619-
SQLUSMALLINT values[4] = {0, 0, 0, 0};
620+
SQLUSMALLINT values[row_status_size] = {0, 0, 0, 0};
620621

621622
ValidateSetStmtAttr(this->stmt, SQL_ATTR_ROW_STATUS_PTR,
622623
static_cast<SQLPOINTER>(values));

0 commit comments

Comments
 (0)