Move the '-Wno-error=deprecated-declarations' to a common target_compile_options

Author: raulcd

cpp/cmake_modules/ThirdpartyToolchain.cmake

@@ -3271,6 +3271,16 @@ function(build_grpc)
     add_executable(gRPC::grpc_cpp_plugin ALIAS grpc_cpp_plugin)
   endif()
 
+  # gRPC headers use deprecated std::iterator that causes compilation errors.
+  # This workaround can be removed once we upgrade to a newer gRPC version.
+  if(NOT MSVC)
+    foreach(target ${GRPC_LIBRARY_TARGETS})
+      if(TARGET ${target})
+        target_compile_options(${target} INTERFACE -Wno-error=deprecated-declarations)
+      endif()
+    endforeach()
+  endif()
+
   # Add gRPC libraries to bundled static libs.
   list(APPEND
        ARROW_BUNDLED_STATIC_LIBS

cpp/examples/arrow/CMakeLists.txt

@@ -127,15 +127,6 @@ if(ARROW_FLIGHT)
                     "${CMAKE_CURRENT_BINARY_DIR}/helloworld.pb.cc"
                     "${CMAKE_CURRENT_BINARY_DIR}/helloworld.grpc.pb.cc")
 
-  # gRPC headers use deprecated std::iterator (deprecated in C++17, removed in C++20).
-  # This causes compilation errors with GCC 15+ when using -Werror.
-  # This workaround can be removed once we upgrade to a newer gRPC version that doesn't
-  # use std::iterator (likely gRPC 1.60+).
-  # TODO: Can't we pass this to add_arrow_example() to apply it to the target directly?
-  if(NOT MSVC)
-    target_compile_options(flight-grpc-example PRIVATE -Wno-error=deprecated-declarations)
-  endif()
-
   if(ARROW_FLIGHT_SQL)
     if(ARROW_BUILD_SHARED AND ARROW_GRPC_USE_SHARED)
       set(FLIGHT_SQL_EXAMPLES_LINK_LIBS arrow_flight_sql_shared)
@@ -152,13 +143,6 @@ if(ARROW_FLIGHT)
                       gRPC::grpc++
                       ${ARROW_PROTOBUF_LIBPROTOBUF}
                       ${GFLAGS_LIBRARIES})
-
-    # gRPC headers use deprecated std::iterator
-    # TODO: Can't we pass this to add_arrow_example() to apply it to the target directly?
-    if(NOT MSVC)
-      target_compile_options(flight-sql-example
-                             PRIVATE -Wno-error=deprecated-declarations)
-    endif()
   endif()
 endif()
 

cpp/src/arrow/flight/CMakeLists.txt

@@ -17,16 +17,6 @@
 
 add_custom_target(arrow_flight)
 
-# gRPC headers use deprecated std::iterator (deprecated in C++17, removed in C++20).
-# This causes compilation errors with GCC 15+ when using -Werror.
-# This workaround can be removed once we upgrade to a newer gRPC version that doesn't
-# use std::iterator (likely gRPC 1.60+).
-# Apply to all Flight targets (libraries, tests, executables) in this directory.
-# TODO: Check whether this is global and try a better approach if so.
-if(NOT MSVC)
-  add_compile_options(-Wno-error=deprecated-declarations)
-endif()
-
 arrow_install_all_headers("arrow/flight")
 
 # If libarrow_flight.a is only built, "pkg-config --cflags --libs