Skip to content

Commit 590aae7

Browse files
committed
GH-47401: [C++] Remove needless Snappy patch
It's in upstream.
1 parent 0ecc472 commit 590aae7

File tree

2 files changed

+0
-41
lines changed

2 files changed

+0
-41
lines changed

cpp/cmake_modules/ThirdpartyToolchain.cmake

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1403,15 +1403,6 @@ macro(build_snappy)
14031403
)
14041404
endforeach()
14051405

1406-
if(APPLE AND CMAKE_HOST_SYSTEM_VERSION VERSION_LESS 20)
1407-
# On macOS 10.13 we need to explicitly add <functional> to avoid a missing include error
1408-
# This can be removed once CRAN no longer checks on macOS 10.13
1409-
find_program(PATCH patch REQUIRED)
1410-
set(SNAPPY_PATCH_COMMAND ${PATCH} -p1 -i ${CMAKE_CURRENT_LIST_DIR}/snappy.diff)
1411-
else()
1412-
set(SNAPPY_PATCH_COMMAND)
1413-
endif()
1414-
14151406
if(CMAKE_SYSTEM_NAME STREQUAL "Emscripten")
14161407
# ignore linker flag errors, as Snappy sets
14171408
# -Werror -Wall, and Emscripten doesn't support -soname
@@ -1426,7 +1417,6 @@ macro(build_snappy)
14261417
INSTALL_DIR ${SNAPPY_PREFIX}
14271418
URL ${SNAPPY_SOURCE_URL}
14281419
URL_HASH "SHA256=${ARROW_SNAPPY_BUILD_SHA256_CHECKSUM}"
1429-
PATCH_COMMAND ${SNAPPY_PATCH_COMMAND}
14301420
CMAKE_ARGS ${SNAPPY_CMAKE_ARGS}
14311421
BUILD_BYPRODUCTS "${SNAPPY_STATIC_LIB}")
14321422

cpp/cmake_modules/snappy.diff

Lines changed: 0 additions & 31 deletions
This file was deleted.

0 commit comments

Comments
 (0)