GH-46236: [Release][Packaging] Fix dev/release/post-03-binary.sh errors (#46237)

### Rationale for this change

There are two problems:

`with_read_timeout` can't set timeout:

    /host/binary-task.rb:463:in `with_read_timeout': undefined method `read_timeout' for nil:NilClass (NoMethodError)

          current_timeout = @ http.read_timeout
                                 ^^^^^^^^^^^^^
            from /host/binary-task.rb:680:in `block in copy'
            from /host/binary-task.rb:442:in `with_retry'
            from /host/binary-task.rb:679:in `copy'
            from /host/binary-task.rb:1100:in `block (3 levels) in release'
            from /host/binary-task.rb:746:in `pull'
            from /host/binary-task.rb:1099:in `block (2 levels) in release'
            from /host/binary-task.rb:48:in `block (3 levels) in initialize'
            from /host/binary-task.rb:45:in `loop'
            from /host/binary-task.rb:45:in `block (2 levels) in initialize'

`yum:release` can't download a distribution:

    ArgumentError: wrong number of arguments (given 3, expected 4)
    /host/binary-task.rb:1266:in `download_distribution'
    /host/binary-task.rb:2129:in `block (3 levels) in define_yum_release_tasks'
    /host/binary-task.rb:2124:in `each'
    /host/binary-task.rb:2124:in `block (2 levels) in define_yum_release_tasks'

### What changes are included in this PR?

* Defer timeout set timing for `with_read_timeout`
* Add missing `type` argument for `yum:release`

### Are these changes tested?

Yes. I used this for 20.0.0.

### Are there any user-facing changes?

No.
* GitHub Issue: #46236

Authored-by: Sutou Kouhei <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>

Author: kou

dev/release/binary-task.rb

@@ -268,6 +268,7 @@ def initialize(request, response, message)
 
     def initialize
       @http = nil
+      @current_timeout = nil
     end
 
     private def start_http(url, &block)
@@ -302,32 +303,38 @@ def request(method, headers, url, body: nil, &block)
     end
 
     private def request_internal(http, request, &block)
-      http.request(request) do |response|
-        case response
-        when Net::HTTPSuccess,
-             Net::HTTPNotModified
-          if block_given?
-            return yield(response)
+      read_timeout = http.read_timeout
+      begin
+        http.read_timeout = @current_timeout if @current_timeout
+        http.request(request) do |response|
+          case response
+          when Net::HTTPSuccess,
+               Net::HTTPNotModified
+            if block_given?
+              return yield(response)
+            else
+              response.read_body
+              return response
+            end
+          when Net::HTTPRedirection
+            redirected_url = URI(response["Location"])
+            redirected_request = Net::HTTP::Get.new(redirected_url, {})
+            start_http(redirected_url) do |redirected_http|
+              request_internal(redirected_http, redirected_request, &block)
+            end
           else
-            response.read_body
-            return response
-          end
-        when Net::HTTPRedirection
-          redirected_url = URI(response["Location"])
-          redirected_request = Net::HTTP::Get.new(redirected_url, {})
-          start_http(redirected_url) do |redirected_http|
-            request_internal(redirected_http, redirected_request, &block)
-          end
-        else
-          message = "failed to request: "
-          message << "#{request.uri}: #{request.method}: "
-          message << "#{response.message} #{response.code}"
-          if response.body
-            message << "\n"
-            message << response.body
+            message = "failed to request: "
+            message << "#{request.uri}: #{request.method}: "
+            message << "#{response.message} #{response.code}"
+            if response.body
+              message << "\n"
+              message << response.body
+            end
+            raise Error.new(request, response, message)
           end
-          raise Error.new(request, response, message)
         end
+      ensure
+        http.read_timeout = read_timeout
       end
     end
 
@@ -460,12 +467,11 @@ def with_retry(max_n_retries, target)
     end
 
     def with_read_timeout(timeout)
-      current_timeout = @http.read_timeout
+      current_timeout, @current_timeout = @current_timeout, timeout
       begin
-        @http.read_timeout = timeout
         yield
       ensure
-        @http.read_timeout = current_timeout
+        @current_timeout = current_timeout
       end
     end
   end
@@ -2125,7 +2131,8 @@ def define_yum_release_tasks
                                list: uploaded_files_name)
 
           distribution_dir = "#{yum_release_repositories_dir}/#{distribution}"
-          download_distribution(distribution,
+          download_distribution(:artifactory,
+                                distribution,
                                 distribution_dir,
                                 :rc,
                                 pattern: /\/repodata\//)