Skip to content

Commit 5fda255

Browse files
committed
Address Sutou's code review comments
1 parent 833824a commit 5fda255

File tree

1 file changed

+8
-4
lines changed

1 file changed

+8
-4
lines changed

cpp/src/arrow/flight/sql/odbc/odbc_api.cc

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,12 @@ SQLRETURN SQLAllocHandle(SQLSMALLINT type, SQLHANDLE parent, SQLHANDLE* result)
3838
<< ", result: " << static_cast<const void*>(result);
3939
// GH-46096 TODO: Implement SQLAllocEnv
4040
// GH-46097 TODO: Implement SQLAllocConnect, pre-requisite requires SQLAllocEnv
41-
// implementation GH-47706 TODO: Implement SQLAllocStmt, pre-requisite requires
42-
// SQLDriverConnect implementation GH-47707 TODO: Implement SQL_HANDLE_DESC for
41+
// implementation
42+
43+
// GH-47706 TODO: Implement SQLAllocStmt, pre-requisite requires
44+
// SQLDriverConnect implementation
45+
46+
// GH-47707 TODO: Implement SQL_HANDLE_DESC for
4347
// descriptor handle, pre-requisite requires SQLAllocStmt
4448
return SQL_INVALID_HANDLE;
4549
}
@@ -176,7 +180,7 @@ SQLRETURN SQLDisconnect(SQLHDBC conn) {
176180

177181
SQLRETURN SQLGetInfo(SQLHDBC conn, SQLUSMALLINT info_type, SQLPOINTER info_value_ptr,
178182
SQLSMALLINT buf_len, SQLSMALLINT* string_length_ptr) {
179-
ARROW_LOG(DEBUG) << "SQLGetInfo called with conn: " << conn
183+
ARROW_LOG(DEBUG) << "SQLGetInfoW called with conn: " << conn
180184
<< ", info_type: " << info_type
181185
<< ", info_value_ptr: " << info_value_ptr << ", buf_len: " << buf_len
182186
<< ", string_length_ptr: "
@@ -311,7 +315,7 @@ SQLRETURN SQLTables(SQLHSTMT stmt, SQLWCHAR* catalog_name,
311315
SQLSMALLINT schema_name_length, SQLWCHAR* table_name,
312316
SQLSMALLINT table_name_length, SQLWCHAR* table_type,
313317
SQLSMALLINT table_type_length) {
314-
ARROW_LOG(DEBUG) << "SQLTables called with stmt: " << stmt
318+
ARROW_LOG(DEBUG) << "SQLTablesW called with stmt: " << stmt
315319
<< ", catalog_name: " << static_cast<const void*>(catalog_name)
316320
<< ", catalog_name_length: " << catalog_name_length
317321
<< ", schema_name: " << static_cast<const void*>(schema_name)

0 commit comments

Comments
 (0)