Skip to content

Commit 6054875

Browse files
raulcdkou
andauthored
Apply suggestions from code review
Co-authored-by: Sutou Kouhei <[email protected]>
1 parent b81600c commit 6054875

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

cpp/cmake_modules/ThirdpartyToolchain.cmake

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3012,8 +3012,8 @@ macro(build_absl)
30123012

30133013
# Configure Abseil options before FetchContent
30143014
set(ABSL_PROPAGATE_CXX_STD ON)
3015-
# We have to enable abseil install to generate abslConfig.cmake
3016-
# so GRPC can find Abseil thorught ExternalProject_Add
3015+
# We have to enable Abseil install to generate abslConfig.cmake
3016+
# so gRPC can find Abseil thorught ExternalProject_Add
30173017
set(ABSL_ENABLE_INSTALL ON)
30183018

30193019
if(CMAKE_COMPILER_IS_GNUCC AND CMAKE_CXX_COMPILER_VERSION VERSION_GREATER_EQUAL 13.0)
@@ -3037,7 +3037,7 @@ macro(build_absl)
30373037
# This custom target is required due to a timing issue between FetchContent
30383038
# and the install command below, which is necessary for GRPC to find Abseil
30393039
# due to mixing FetchContent and ExternalProject_Add.
3040-
# Create a target that depends on ALL Abseil libraries that will be installed
3040+
# Create a target that depends on ALL Abseil libraries that will be installed.
30413041
# This ensures they're all built before we try to install.
30423042
add_custom_target(absl_built
30433043
DEPENDS absl::bad_any_cast_impl
@@ -3107,7 +3107,7 @@ macro(build_absl)
31073107
absl::time
31083108
absl::time_zone)
31093109

3110-
# GRPC requires Abseil to be installed to a known location.
3110+
# gRPC requires Abseil to be installed to a known location.
31113111
# We have to do this in two steps to avoid double installation of Abseil
31123112
# when Arrow is installed.
31133113
# Disable Abseil's install script this target runs after Abseil is built
@@ -3127,9 +3127,9 @@ macro(build_absl)
31273127
add_custom_target(absl_install_disabled ALL
31283128
DEPENDS "${absl_BINARY_DIR}/cmake_install.cmake.saved")
31293129

3130-
# Install Abseil to ABSL_PREFIX for gRPC to find
3130+
# Install Abseil to ABSL_PREFIX for gRPC to find.
31313131
# Using the saved original cmake_install.cmake.saved install script
3132-
# for other dependencies to find Abseil
3132+
# for other dependencies to find Abseil.
31333133
add_custom_command(OUTPUT "${ABSL_PREFIX}/.absl_installed"
31343134
COMMAND ${CMAKE_COMMAND} -E copy_if_different
31353135
"${absl_BINARY_DIR}/cmake_install.cmake.saved"

0 commit comments

Comments
 (0)