Commit 6657a92
authored
### Rationale for this change
The XXX comment in `SharedExclusiveChecker` noted that error messages were too generic and didn't describe the actual operations involved.
**Shared lock:**
`ReadAt()`:
https://github.com/apache/arrow/blob/7be5a89ef083f38317fd94330127be5b5df648d8/cpp/src/arrow/io/concurrency.h#L210-L212
https://github.com/apache/arrow/blob/7be5a89ef083f38317fd94330127be5b5df648d8/cpp/src/arrow/io/concurrency.h#L215-L217
`GetSize()`:
https://github.com/apache/arrow/blob/7be5a89ef083f38317fd94330127be5b5df648d8/cpp/src/arrow/io/concurrency.h#L199-L201
**Exclusive lock:**
`Read()`:
https://github.com/apache/arrow/blob/7be5a89ef083f38317fd94330127be5b5df648d8/cpp/src/arrow/io/concurrency.h#L109-L111
https://github.com/apache/arrow/blob/7be5a89ef083f38317fd94330127be5b5df648d8/cpp/src/arrow/io/concurrency.h#L114-L116
https://github.com/apache/arrow/blob/7be5a89ef083f38317fd94330127be5b5df648d8/cpp/src/arrow/io/concurrency.h#L179-L181
https://github.com/apache/arrow/blob/7be5a89ef083f38317fd94330127be5b5df648d8/cpp/src/arrow/io/concurrency.h#L184-L186
`Seek()`:
https://github.com/apache/arrow/blob/7be5a89ef083f38317fd94330127be5b5df648d8/cpp/src/arrow/io/concurrency.h#L194-L196
`Tell()`:
https://github.com/apache/arrow/blob/7be5a89ef083f38317fd94330127be5b5df648d8/cpp/src/arrow/io/concurrency.h#L104-L106
https://github.com/apache/arrow/blob/7be5a89ef083f38317fd94330127be5b5df648d8/cpp/src/arrow/io/concurrency.h#L174-L176
`Peek()`:
https://github.com/apache/arrow/blob/7be5a89ef083f38317fd94330127be5b5df648d8/cpp/src/arrow/io/concurrency.h#L119-L121
https://github.com/apache/arrow/blob/7be5a89ef083f38317fd94330127be5b5df648d8/cpp/src/arrow/io/concurrency.h#L189-L191
`Close()`:
https://github.com/apache/arrow/blob/7be5a89ef083f38317fd94330127be5b5df648d8/cpp/src/arrow/io/concurrency.h#L94-L96
https://github.com/apache/arrow/blob/7be5a89ef083f38317fd94330127be5b5df648d8/cpp/src/arrow/io/concurrency.h#L164-L166
`Abort()`:
https://github.com/apache/arrow/blob/7be5a89ef083f38317fd94330127be5b5df648d8/cpp/src/arrow/io/concurrency.h#L99-L101
https://github.com/apache/arrow/blob/7be5a89ef083f38317fd94330127be5b5df648d8/cpp/src/arrow/io/concurrency.h#L169-L171
### What changes are included in this PR?
Improved three error messages in `SharedExclusiveChecker` to explicitly list the I/O operations involved:
- Shared lock operations: `ReadAt`, `GetSize`
- Exclusive lock operations: `Read`, `Seek`, `Tell`, `Peek`, `Close`, `Abort`
### Are these changes tested?
I manually tested all of combinations.
### Are there any user-facing changes?
No.
* GitHub Issue: #48799
Authored-by: Hyukjin Kwon <gurwls223@apache.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
1 parent 985b16e commit 6657a92
1 file changed
+6
-5
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
338 | 338 | | |
339 | 339 | | |
340 | 340 | | |
341 | | - | |
342 | | - | |
343 | 341 | | |
344 | | - | |
| 342 | + | |
| 343 | + | |
345 | 344 | | |
346 | 345 | | |
347 | 346 | | |
| |||
354 | 353 | | |
355 | 354 | | |
356 | 355 | | |
357 | | - | |
| 356 | + | |
| 357 | + | |
358 | 358 | | |
359 | | - | |
| 359 | + | |
| 360 | + | |
360 | 361 | | |
361 | 362 | | |
362 | 363 | | |
| |||
0 commit comments