Commit 69d2487
authored
### Rationale for this change
This is the sub issue #44748.
* SC1091: Not following
* SC2012: Use `find` instead of `ls` to better handle non-alphanumeric filenames.
* SC2086: Double quote to prevent globbing and word splitting
```
heck ci/scripts/python_sdist_test.sh
In ci/scripts/python_sdist_test.sh line 56:
sdist=$(ls ${arrow_dir}/python/dist/pyarrow-*.tar.gz | sort -r | head -n1)
^-- SC2012 (info): Use find instead of ls to better handle non-alphanumeric filenames.
^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
sdist=$(ls "${arrow_dir}"/python/dist/pyarrow-*.tar.gz | sort -r | head -n1)
In ci/scripts/python_sdist_test.sh line 60:
. "${ARROW_PYTHON_VENV}/bin/activate"
^-- SC1091 (info): Not following: ./bin/activate: openBinaryFile: does not exist (No such file or directory)
In ci/scripts/python_sdist_test.sh line 63:
${PYTHON:-python} -m pip install ${sdist}
^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
${PYTHON:-python} -m pip install "${sdist}"
In ci/scripts/python_sdist_test.sh line 65:
pytest -r s ${PYTEST_ARGS:-} --pyargs pyarrow
^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
pytest -r s "${PYTEST_ARGS:-}" --pyargs pyarrow
For more information:
https://www.shellcheck.net/wiki/SC1091 -- Not following: ./bin/activate: op...
https://www.shellcheck.net/wiki/SC2012 -- Use find instead of ls to better ...
https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...
```
### What changes are included in this PR?
* SC1091: Skip file check
* SC2012: Use `find` instead of `ls` command
* SC2086: Quote variables
### Are these changes tested?
Yes.
### Are there any user-facing changes?
No.
* GitHub Issue: #47321
Authored-by: Hiroyuki Sato <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
1 parent 71a7b55 commit 69d2487
2 files changed
+8
-3
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
341 | 341 | | |
342 | 342 | | |
343 | 343 | | |
| 344 | + | |
344 | 345 | | |
345 | 346 | | |
346 | 347 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
53 | 53 | | |
54 | 54 | | |
55 | 55 | | |
56 | | - | |
| 56 | + | |
57 | 57 | | |
58 | 58 | | |
59 | 59 | | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
60 | 64 | | |
61 | 65 | | |
62 | 66 | | |
63 | | - | |
| 67 | + | |
64 | 68 | | |
65 | | - | |
| 69 | + | |
0 commit comments