Commit 6a9e2d5
### Rationale for this change
Fixes the dropped `pa.schema` metadata reported in #38575, which was introduced in #37797.
### What changes are included in this PR?
Passes through the `metadata` to the short-circuited `Schema` created with `_import_from_c_capsule`.
### Are these changes tested?
Yes - added `metadata` to the existing test.
### Are there any user-facing changes?
I'm not sure this quite rises to the `(b) a bug that caused incorrect or invalid data to be produced,` condition, but I added that note to be safe since the resulting schema is "incorrect" (and broke some round-trip tests on my end after a pyarrow update):
**This PR contains a "Critical Fix".**
* GitHub Issue: #38575
Lead-authored-by: Jacob Hayes <jacob.r.hayes@gmail.com>
Co-authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
1 parent dc973c2 commit 6a9e2d5
2 files changed
+8
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1331 | 1331 | | |
1332 | 1332 | | |
1333 | 1333 | | |
1334 | | - | |
| 1334 | + | |
| 1335 | + | |
1335 | 1336 | | |
1336 | 1337 | | |
1337 | 1338 | | |
| 1339 | + | |
| 1340 | + | |
1338 | 1341 | | |
1339 | 1342 | | |
1340 | 1343 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5332 | 5332 | | |
5333 | 5333 | | |
5334 | 5334 | | |
5335 | | - | |
| 5335 | + | |
| 5336 | + | |
| 5337 | + | |
| 5338 | + | |
5336 | 5339 | | |
5337 | 5340 | | |
5338 | 5341 | | |
| |||
0 commit comments