GH-47554: [C++] Fix Meson Parquet symbol visibility issues

Author: WillAyd

cpp/src/arrow/meson.build

@@ -488,8 +488,7 @@ arrow_lib = library(
     include_directories: arrow_includes,
     dependencies: arrow_deps,
     install: true,
-    # TODO: re-enable symbol visibility
-    #gnu_symbol_visibility: 'inlineshidden',
+    gnu_symbol_visibility: 'inlineshidden',
     cpp_shared_args: ['-DARROW_EXPORTING'],
 )
 

cpp/src/arrow/util/visibility.h

@@ -78,7 +78,7 @@
 #  endif
 
 #  define ARROW_FRIEND_EXPORT
-#  define ARROW_TEMPLATE_EXPORT
+#  define ARROW_TEMPLATE_EXPORT ARROW_EXPORT
 
 // [[gnu::visibility("default")]] even when #included by a non-arrow source
 #  define ARROW_FORCE_EXPORT [[gnu::visibility("default")]]

cpp/src/parquet/meson.build

@@ -89,7 +89,7 @@ endif
 
 parquet_deps = [arrow_dep, rapidjson_dep, thrift_dep]
 
-if needs_parquet_encryption or get_option('parquet_require_encryption') == 'auto'
+if needs_parquet_encryption or get_option('parquet_require_encryption').auto()
     openssl_dep = dependency('openssl', required: needs_parquet_encryption)
 else
     openssl_dep = disabler()
@@ -120,8 +120,7 @@ parquet_lib = library(
     'arrow-parquet',
     sources: parquet_srcs,
     dependencies: parquet_deps,
-    # TODO: enable hidden visibility by default
-    #gnu_symbol_visibility: 'inlineshidden',
+    gnu_symbol_visibility: 'inlineshidden',
 )
 
 parquet_dep = declare_dependency(link_with: parquet_lib)
@@ -271,6 +270,19 @@ endif
 
 parquet_test_dep = [parquet_dep, arrow_test_dep, thrift_dep]
 
+if get_option('default_library') != 'static'
+    parquet_test_support_lib = static_library(
+        'parquet-test-support',
+        sources: files('../generated/parquet_types.cpp'),
+        dependencies: [thrift_dep],
+        include_directories: include_directories('..'),
+    )
+    parquet_test_support_dep = declare_dependency(
+        link_with: [parquet_test_support_lib],
+    )
+    parquet_test_dep += [parquet_test_support_dep]
+endif
+
 foreach key, val : parquet_tests
     test_name = 'parquet-@0@'.format(key)
     exc = executable(