Non-meson configuration cleanups

Author: WillAyd

.github/workflows/python.yml

@@ -174,6 +174,8 @@ jobs:
       ARROW_WITH_BROTLI: ON
       ARROW_BUILD_TESTS: OFF
       PYARROW_TEST_LARGE_MEMORY: ON
+      # Current oldest supported version according to https://endoflife.date/macos
+      MACOSX_DEPLOYMENT_TARGET: "12.0"
     steps:
       - name: Checkout Arrow
         uses: actions/checkout@v5
@@ -290,12 +292,6 @@ jobs:
         shell: cmd
         run: |
           call "ci\scripts\python_build.bat" %cd% "${{ steps.path-info.outputs.usr-windows-dir }}"
-      - name: Upload wheel
-        if: always()                     # ensures this runs even on failure
-        uses: actions/upload-artifact@v4
-        with:
-          name: built-wheel
-          path: python/wheelhouse/*.whl
       - name: Test PyArrow
         shell: cmd
         run: |

ci/scripts/python_build.bat

@@ -136,8 +136,8 @@ pushd %SOURCE_DIR%\python
 
 @REM by default, CMake installs .lib import libs to lib and .dll libs to bin
 @REM delvewheel requires these to be side-by-side to properly vendor
+@REM https://github.com/adang1345/delvewheel/issues/66
 copy %CMAKE_INSTALL_PREFIX%\lib\*.lib %CMAKE_INSTALL_PREFIX%\bin\
-dir %CMAKE_INSTALL_PREFIX%\bin\
 
 @REM Build PyArrow
 %PYTHON_CMD% -m build --wheel . --no-isolation || exit /B 1

ci/scripts/python_build.sh

@@ -126,8 +126,8 @@ pushd "${python_build_dir}"
 # - Cannot use build isolation as we want to use specific dependency versions
 #   (e.g. Numpy, Pandas) on some CI jobs.
 
-# The conda compilers package may mess with C{XX}_FLAGS in a way that interferes
-# with the compiler
+# The conda compilers package adds flags for debugging and optimization
+# that are unnecessary in a CI context
 OLD_CFLAGS=$CFLAGS
 OLD_CPPFLAGS=$CPPFLAGS
 OLD_CXXFLAGS=$CXXFLAGS

ci/scripts/python_test.bat

@@ -37,6 +37,5 @@ pushd %SOURCE_DIR%\python
 popd
 
 @REM Run Python tests
-dir C:\hostedtoolcache\windows\Python\3.13.9\x64\Lib\site-packages\pyarrow
 %PYTHON_CMD% -c "import pyarrow" || exit /B 1
 %PYTHON_CMD% -m pytest -r s --pyargs pyarrow || exit /B 1

ci/scripts/python_wheel_macos_build.sh

@@ -34,7 +34,7 @@ rm -rf ${source_dir}/python/pyarrow/*.so.*
 
 echo "=== (${PYTHON_VERSION}) Set SDK, C++ and Wheel flags ==="
 export _PYTHON_HOST_PLATFORM="macosx-${MACOSX_DEPLOYMENT_TARGET}-${arch}"
-export MACOSX_DEPLOYMENT_TARGET=${MACOSX_DEPLOYMENT_TARGET:-14.0}
+export MACOSX_DEPLOYMENT_TARGET=${MACOSX_DEPLOYMENT_TARGET:-12.0}
 export SDKROOT=${SDKROOT:-$(xcrun --sdk macosx --show-sdk-path)}
 
 if [ $arch = "arm64" ]; then

cpp/cmake_modules/BuildUtils.cmake

@@ -315,7 +315,7 @@ function(ADD_ARROW_LIB LIB_NAME)
   if(ARG_INSTALL_RUNTIME_DIR)
     set(INSTALL_RUNTIME_DIR ${ARG_INSTALL_RUNTIME_DIR})
   else()
-    set(INSTALL_RUNTIME_DIR ${CMAKE_INSTALL_BINDIR})
+    set(INSTALL_RUNTIME_DIR bin)
   endif()
 
   if(BUILD_SHARED)

cpp/meson.build

@@ -22,9 +22,7 @@ project(
     version: '23.0.0-SNAPSHOT',
     license: 'Apache-2.0',
     meson_version: '>=1.3.0',
-    # TODO: revert after https://github.com/mesonbuild/meson/issues/15202
-    # OR figure out if we even need gnu11
-    default_options: ['c_std=c11', 'warning_level=2', 'cpp_std=c++17'],
+    default_options: ['c_std=gnu11,c11', 'warning_level=2', 'cpp_std=c++17'],
 )
 
 project_args = [

dev/tasks/verify-rc/github.macos.yml

@@ -22,7 +22,7 @@
 {% set use_conda = use_conda|default(False) %}
 # env: is generated by macros.github_header()
   # Current oldest supported version according to https://endoflife.date/macos
-  MACOSX_DEPLOYMENT_TARGET: "14.0"
+  MACOSX_DEPLOYMENT_TARGET: "12.0"
 
 jobs:
   verify:

python/examples/minimal_build/build_venv.sh

@@ -70,7 +70,7 @@ export PYARROW_BUILD_TYPE=Debug
 export PYARROW_CMAKE_GENERATOR=Ninja
 
 # Use the same command that we use on python_build.sh
-python -m pip install --no-deps --no-build-isolation -vv . -Csetup-args="--pkg-config-path=$ARROW_HOME/lib/pkgconfig"
+python -m pip install --no-deps --no-build-isolation -vv .
 
 popd
 

python/pyarrow/__init__.py

@@ -36,19 +36,6 @@
 import sys as _sys
 import warnings as _warnings
 
-
-def _append_to_sharedlib_load_path():
-    # https://mesonbuild.com/meson-python/how-to-guides/shared-libraries.html
-    basedir = _os.path.dirname(__file__)
-    if _os.name == 'nt':
-        _os.add_dll_directory(basedir)
-    elif _sys.platform == 'cygwin':
-        _os.environ['PATH'] = _os.pathsep.join((_os.environ['PATH'], basedir))
-
-
-_append_to_sharedlib_load_path()
-
-
 try:
     from ._generated_version import version as __version__
 except ImportError:
@@ -404,9 +391,13 @@ def get_library_dirs():
     linking C or Cython extensions using pyarrow
     """
     package_cwd = _os.path.dirname(__file__)
-    library_dirs = [
-        package_cwd, _os.path.join(_os.path.dirname(package_cwd), "pyarrow.libs")
-    ]
+    library_dirs = [package_cwd]
+
+    # delvewheel creates a top level pyarrow.libs to vendor external shared libraries
+    if _os.name == "nt":
+        library_dirs.append(
+            _os.path.join(_os.path.dirname(package_cwd), "pyarrow.libs")
+        )
 
     def append_library_dir(library_dir):
         if library_dir not in library_dirs: