Commit 8c16a08
authored
### Rationale for this change
GitHub allows repositories to set up immutable GitHub releases. Immutable releases won't allow for artifacts to be published to the release once the release is published and out of draft-mode. The release immutability has to be set up per repository (or organization).
### What changes are included in this PR?
Create the Release Candidate GitHub release as draft in order to allow for immutable releases to be set up on the repository.
Addition of artifacts will be available to the RC release but won't be available to the official release as we upload all artifacts as part of the release creation.
Publish the RC release once no new artifacts have to be uploaded.
### Are these changes tested?
Not as part of a release but I've created a release on my fork and tested the workflow. See:
https://github.com/raulcd/arrow/releases/tag/raul-test-release-immutable
I've validated that when immutable releases are configured on the repository:
- artifacts can be uploaded when the release is in draft mode.
- Release can be edited on draft mode
- Once the draft mode is removed no new artifacts can be uploaded
- The release can be edited (add final release notes) when the release is not in draft mode, allowing for our workflow of the release to add the final release notes without problems.
### Are there any user-facing changes?
No but users will be able to validate the artifacts have not been updated/changed since the release was done due to immutability.
* GitHub Issue: #48000
Authored-by: Raúl Cumplido <[email protected]>
Signed-off-by: Raúl Cumplido <[email protected]>
1 parent c10847c commit 8c16a08
File tree
3 files changed
+42
-0
lines changed- .github/workflows
- dev/release
- docs/source/developers
3 files changed
+42
-0
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
112 | 112 | | |
113 | 113 | | |
114 | 114 | | |
| 115 | + | |
115 | 116 | | |
116 | 117 | | |
117 | 118 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
266 | 266 | | |
267 | 267 | | |
268 | 268 | | |
| 269 | + | |
| 270 | + | |
| 271 | + | |
269 | 272 | | |
270 | 273 | | |
271 | 274 | | |
| |||
0 commit comments