Commit 8ef974c
authored
### Rationale for this change
* SC1090: Can't follow non-constant source. Use a directive to specify location
* SC2086: Double quote to prevent globbing and word splitting
```
In ci/scripts/python_build_emscripten.sh line 26:
source ~/emsdk/emsdk_env.sh
^------------------^ SC1090 (warning): ShellCheck can't follow non-constant source. Use a directive to specify location.
In ci/scripts/python_build_emscripten.sh line 31:
rm -rf ${python_build_dir}
^-----------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
rm -rf "${python_build_dir}"
In ci/scripts/python_build_emscripten.sh line 32:
cp -aL ${source_dir} ${python_build_dir}
^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^-----------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
cp -aL "${source_dir}" "${python_build_dir}"
In ci/scripts/python_build_emscripten.sh line 38:
pushd ${python_build_dir}
^-----------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
pushd "${python_build_dir}"
For more information:
https://www.shellcheck.net/wiki/SC1090 -- ShellCheck can't follow non-const...
https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...
```
### What changes are included in this PR?
* SC1090: disable source file check.
* SC2086: Quote variables.
### Are these changes tested?
Yes.
### Are there any user-facing changes?
No.
* GitHub Issue: #47289
Authored-by: Hiroyuki Sato <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
1 parent 135357c commit 8ef974c
File tree
2 files changed
+8
-4
lines changed- ci/scripts
2 files changed
+8
-4
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
338 | 338 | | |
339 | 339 | | |
340 | 340 | | |
| 341 | + | |
341 | 342 | | |
342 | 343 | | |
343 | 344 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
25 | | - | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
26 | 29 | | |
27 | 30 | | |
28 | 31 | | |
29 | 32 | | |
30 | 33 | | |
31 | | - | |
32 | | - | |
| 34 | + | |
| 35 | + | |
33 | 36 | | |
34 | 37 | | |
35 | 38 | | |
36 | 39 | | |
37 | 40 | | |
38 | | - | |
| 41 | + | |
39 | 42 | | |
40 | 43 | | |
0 commit comments