GH-47518: [C++][FlightRPC] Replace spdlogs with Arrow's Internal Logging (#47645)

### Rationale for this change
 Replace `spdlogs` with Arrow's Internal Logging. 

### What changes are included in this PR?
- removed `spdlogs` fetch and build
- replaced odbc logging framework with Arrow's internal logging
- Build fixes:
    - use C++ 20
    - dsn window minor static cast fix

### Are these changes tested?
- yes, on local Windows environment

### Are there any user-facing changes?
No
* GitHub Issue: #47518

Lead-authored-by: Alina (Xi) Li <[email protected]>
Co-authored-by: Alina (Xi) Li <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>

Author: alinaliBQ

cpp/src/arrow/flight/sql/odbc/CMakeLists.txt

@@ -17,5 +17,9 @@
 
 add_custom_target(arrow_flight_sql_odbc)
 
+# Use C++ 20 for ODBC and its subdirectory
+# GH-44792: Arrow will switch to C++ 20
+set(CMAKE_CXX_STANDARD 20)
+
 add_subdirectory(flight_sql)
 add_subdirectory(odbcabstraction)

cpp/src/arrow/flight/sql/odbc/flight_sql/flight_sql_driver.cc

@@ -18,41 +18,31 @@
 #include "arrow/flight/sql/odbc/flight_sql/include/flight_sql/flight_sql_driver.h"
 #include "arrow/flight/sql/odbc/flight_sql/flight_sql_connection.h"
 #include "arrow/flight/sql/odbc/odbcabstraction/include/odbcabstraction/platform.h"
-#include "arrow/flight/sql/odbc/odbcabstraction/include/odbcabstraction/spd_logger.h"
-#include "arrow/flight/sql/odbc/odbcabstraction/include/odbcabstraction/utils.h"
+#include "arrow/util/io_util.h"
+#include "arrow/util/logging.h"
+#include "arrow/util/string.h"
 
-#define DEFAULT_MAXIMUM_FILE_SIZE 16777216
-#define CONFIG_FILE_NAME "arrow-odbc.ini"
+using arrow::util::ArrowLogLevel;
 
 namespace driver {
 namespace flight_sql {
+static constexpr const char* kODBCLogLevel = "ARROW_ODBC_LOG_LEVEL";
 
 using odbcabstraction::Connection;
-using odbcabstraction::LogLevel;
 using odbcabstraction::OdbcVersion;
-using odbcabstraction::SPDLogger;
 
-namespace {
-LogLevel ToLogLevel(int64_t level) {
-  switch (level) {
-    case 0:
-      return LogLevel::LogLevel_TRACE;
-    case 1:
-      return LogLevel::LogLevel_DEBUG;
-    case 2:
-      return LogLevel::LogLevel_INFO;
-    case 3:
-      return LogLevel::LogLevel_WARN;
-    case 4:
-      return LogLevel::LogLevel_ERROR;
-    default:
-      return LogLevel::LogLevel_OFF;
-  }
+FlightSqlDriver::FlightSqlDriver()
+    : diagnostics_("Apache Arrow", "Flight SQL", OdbcVersion::V_3), version_("0.9.0.0") {
+  RegisterLog();
 }
-}  // namespace
 
-FlightSqlDriver::FlightSqlDriver()
-    : diagnostics_("Apache Arrow", "Flight SQL", OdbcVersion::V_3), version_("0.9.0.0") {}
+FlightSqlDriver::~FlightSqlDriver() {
+  // Unregister log if logging is enabled
+  if (arrow::internal::GetEnvVar(kODBCLogLevel).ValueOr("").empty()) {
+    return;
+  }
+  arrow::util::ArrowLog::ShutDownArrowLog();
+}
 
 std::shared_ptr<Connection> FlightSqlDriver::CreateConnection(OdbcVersion odbc_version) {
   return std::make_shared<FlightSqlConnection>(odbc_version, version_);
@@ -63,45 +53,36 @@ odbcabstraction::Diagnostics& FlightSqlDriver::GetDiagnostics() { return diagnos
 void FlightSqlDriver::SetVersion(std::string version) { version_ = std::move(version); }
 
 void FlightSqlDriver::RegisterLog() {
-  odbcabstraction::PropertyMap propertyMap;
-  driver::odbcabstraction::ReadConfigFile(propertyMap, CONFIG_FILE_NAME);
-
-  auto log_enable_iterator = propertyMap.find(SPDLogger::LOG_ENABLED);
-  auto log_enabled = log_enable_iterator != propertyMap.end()
-                         ? odbcabstraction::AsBool(log_enable_iterator->second)
-                         : false;
-  if (!log_enabled) {
+  std::string log_level_str = arrow::internal::GetEnvVar(kODBCLogLevel)
+                                  .Map(arrow::internal::AsciiToLower)
+                                  .Map(arrow::internal::TrimString)
+                                  .ValueOr("");
+  if (log_level_str.empty()) {
     return;
   }
 
-  auto log_path_iterator = propertyMap.find(SPDLogger::LOG_PATH);
-  auto log_path = log_path_iterator != propertyMap.end() ? log_path_iterator->second : "";
-  if (log_path.empty()) {
-    return;
+  auto log_level = ArrowLogLevel::ARROW_DEBUG;
+
+  if (log_level_str == "fatal") {
+    log_level = ArrowLogLevel::ARROW_FATAL;
+  } else if (log_level_str == "error") {
+    log_level = ArrowLogLevel::ARROW_ERROR;
+  } else if (log_level_str == "warning") {
+    log_level = ArrowLogLevel::ARROW_WARNING;
+  } else if (log_level_str == "info") {
+    log_level = ArrowLogLevel::ARROW_INFO;
+  } else if (log_level_str == "debug") {
+    log_level = ArrowLogLevel::ARROW_DEBUG;
+  } else if (log_level_str == "trace") {
+    log_level = ArrowLogLevel::ARROW_TRACE;
   }
 
-  auto log_level_iterator = propertyMap.find(SPDLogger::LOG_LEVEL);
-  auto log_level = ToLogLevel(log_level_iterator != propertyMap.end()
-                                  ? std::stoi(log_level_iterator->second)
-                                  : 1);
-  if (log_level == odbcabstraction::LogLevel_OFF) {
-    return;
+  // Enable driver logging. Log files are not supported on Windows yet, since GLOG is not
+  // tested fully on Windows.
+  // Info log level is enabled by default.
+  if (log_level != ArrowLogLevel::ARROW_INFO) {
+    arrow::util::ArrowLog::StartArrowLog("arrow-flight-sql-odbc", log_level);
   }
-
-  auto maximum_file_size_iterator = propertyMap.find(SPDLogger::MAXIMUM_FILE_SIZE);
-  auto maximum_file_size = maximum_file_size_iterator != propertyMap.end()
-                               ? std::stoi(maximum_file_size_iterator->second)
-                               : DEFAULT_MAXIMUM_FILE_SIZE;
-
-  auto maximum_file_quantity_iterator = propertyMap.find(SPDLogger::FILE_QUANTITY);
-  auto maximum_file_quantity = maximum_file_quantity_iterator != propertyMap.end()
-                                   ? std::stoi(maximum_file_quantity_iterator->second)
-                                   : 1;
-
-  std::unique_ptr<odbcabstraction::SPDLogger> logger(new odbcabstraction::SPDLogger());
-
-  logger->init(maximum_file_quantity, maximum_file_size, log_path, log_level);
-  odbcabstraction::Logger::SetInstance(std::move(logger));
 }
 
 }  // namespace flight_sql

cpp/src/arrow/flight/sql/odbc/flight_sql/include/flight_sql/flight_sql_driver.h

@@ -30,6 +30,7 @@ class FlightSqlDriver : public odbcabstraction::Driver {
 
  public:
   FlightSqlDriver();
+  ~FlightSqlDriver();
 
   std::shared_ptr<odbcabstraction::Connection> CreateConnection(
       odbcabstraction::OdbcVersion odbc_version) override;

cpp/src/arrow/flight/sql/odbc/flight_sql/ui/dsn_configuration_window.cc

@@ -280,7 +280,7 @@ int DsnConfigurationWindow::CreateEncryptionSettingsGroup(int posX, int posY, in
       rightCheckPosX, rowPos - 2, 20, 2 * ROW_HEIGHT, "",
       ChildId::DISABLE_CERT_VERIFICATION_CHECKBOX, disableCertVerification);
 
-  rowPos += INTERVAL + static_cast<int>(1.5 * ROW_HEIGHT);
+  rowPos += INTERVAL + static_cast<int>(1.5 * static_cast<int>(ROW_HEIGHT));
 
   encryptionSettingsGroupBox =
       CreateGroupBox(posX, posY, sizeX, rowPos - posY, "Encryption settings",

cpp/src/arrow/flight/sql/odbc/odbcabstraction/CMakeLists.txt

@@ -25,9 +25,7 @@ add_library(odbcabstraction
             include/odbcabstraction/diagnostics.h
             include/odbcabstraction/error_codes.h
             include/odbcabstraction/exceptions.h
-            include/odbcabstraction/logger.h
             include/odbcabstraction/platform.h
-            include/odbcabstraction/spd_logger.h
             include/odbcabstraction/types.h
             include/odbcabstraction/utils.h
             include/odbcabstraction/odbc_impl/attribute_utils.h
@@ -47,8 +45,6 @@ add_library(odbcabstraction
             diagnostics.cc
             encoding.cc
             exceptions.cc
-            logger.cc
-            spd_logger.cc
             utils.cc
             ../../../../vendored/whereami/whereami.cc
             odbc_impl/odbc_connection.cc
@@ -65,20 +61,3 @@ set_target_properties(odbcabstraction
                                  ${CMAKE_BINARY_DIR}/$<CONFIG>/lib
                                  RUNTIME_OUTPUT_DIRECTORY
                                  ${CMAKE_BINARY_DIR}/$<CONFIG>/lib)
-
-include(FetchContent)
-fetchcontent_declare(spdlog
-                     URL https://github.com/gabime/spdlog/archive/76fb40d95455f249bd70824ecfcae7a8f0930fa3.zip
-                         CONFIGURE_COMMAND
-                         ""
-                         BUILD_COMMAND
-                         "")
-fetchcontent_getproperties(spdlog)
-if(NOT spdlog_POPULATED)
-  fetchcontent_populate(spdlog)
-endif()
-
-add_library(spdlog INTERFACE)
-target_include_directories(spdlog INTERFACE ${spdlog_SOURCE_DIR}/include)
-
-target_link_libraries(odbcabstraction PUBLIC spdlog)

cpp/src/arrow/flight/sql/odbc/odbcabstraction/include/odbcabstraction/logger.h

@@ -17,10 +17,8 @@
 
 #pragma once
 
-#include <arrow/flight/sql/odbc/odbcabstraction/include/odbcabstraction/logger.h>
-#include <arrow/flight/sql/odbc/odbcabstraction/include/odbcabstraction/spi/connection.h>
-#include <boost/algorithm/string.hpp>
 #include <string>
+#include "arrow/flight/sql/odbc/odbcabstraction/include/odbcabstraction/spi/connection.h"
 
 namespace driver {
 namespace odbcabstraction {
@@ -51,8 +49,5 @@ boost::optional<bool> AsBool(const Connection::ConnPropertyMap& connPropertyMap,
 boost::optional<int32_t> AsInt32(int32_t min_value,
                                  const Connection::ConnPropertyMap& connPropertyMap,
                                  const std::string_view& property_name);
-
-void ReadConfigFile(PropertyMap& properties, const std::string& configFileName);
-
 }  // namespace odbcabstraction
 }  // namespace driver