Skip to content

Commit 9c247a5

Browse files
authored
GH-48446: [Python] Remove todo of schema=name mismatch in record_batches (#48447)
### Rationale for this change https://github.com/apache/arrow/blob/6456944f5092dedb3f80d9bc80400e857d6571c7/python/pyarrow/tests/strategies.py#L393-L394 2b36521e52 fixed the issue by: ```diff - return pa.RecordBatch.from_arrays(children, names=schema) + return pa.RecordBatch.from_arrays(children, schema=schema) ``` so this todo can be removed. ### What changes are included in this PR? This PR removes an obsolete todo. ### Are these changes tested? No, I removed a comment and did not test this. ### Are there any user-facing changes? No, test-only. * GitHub Issue: #48446 Authored-by: Hyukjin Kwon <[email protected]> Signed-off-by: AlenkaF <[email protected]>
1 parent 7e5cbb4 commit 9c247a5

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

python/pyarrow/tests/strategies.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -390,8 +390,6 @@ def record_batches(draw, type, rows=None, max_fields=None):
390390

391391
schema = draw(schemas(type, max_fields=max_fields))
392392
children = [draw(arrays(field.type, size=rows)) for field in schema]
393-
# TODO(kszucs): the names and schema arguments are not consistent with
394-
# Table.from_array's arguments
395393
return pa.RecordBatch.from_arrays(children, schema=schema)
396394

397395

0 commit comments

Comments
 (0)