Skip to content

Commit 9d19450

Browse files
authored
GH-44700: [C++][Parquet] Remove obsolete parquet_constants generated files from old thrift (#44772)
### Rationale for this change The files were generated 4 years ago with and old version of Thrift and don't seem necessary anymore. ### What changes are included in this PR? Remove obsolete files. ### Are these changes tested? No new tests added, just validate tests pass. ### Are there any user-facing changes? No * GitHub Issue: #44700 Authored-by: Raúl Cumplido <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
1 parent 6134b2e commit 9d19450

File tree

5 files changed

+0
-48
lines changed

5 files changed

+0
-48
lines changed

cpp/build-support/lint_exclusions.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
*RcppExports.cpp*
44
*_generated*
55
*arrowExports.cpp*
6-
*parquet_constants.*
76
*parquet_types.*
87
*pyarrow_api.h
98
*pyarrow_lib.h

cpp/src/generated/parquet_constants.cpp

Lines changed: 0 additions & 17 deletions
This file was deleted.

cpp/src/generated/parquet_constants.h

Lines changed: 0 additions & 24 deletions
This file was deleted.

cpp/src/parquet/CMakeLists.txt

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -140,8 +140,6 @@ set(PARQUET_THRIFT_SOURCE_DIR "${ARROW_SOURCE_DIR}/src/generated/")
140140

141141
set_source_files_properties("${PARQUET_THRIFT_SOURCE_DIR}/parquet_types.cpp"
142142
"${PARQUET_THRIFT_SOURCE_DIR}/parquet_types.h"
143-
"${PARQUET_THRIFT_SOURCE_DIR}/parquet_constants.cpp"
144-
"${PARQUET_THRIFT_SOURCE_DIR}/parquet_constants.h"
145143
PROPERTIES SKIP_PRECOMPILE_HEADERS ON
146144
SKIP_UNITY_BUILD_INCLUSION ON)
147145

@@ -178,7 +176,6 @@ set(PARQUET_SRCS
178176
metadata.cc
179177
xxhasher.cc
180178
page_index.cc
181-
"${PARQUET_THRIFT_SOURCE_DIR}/parquet_constants.cpp"
182179
"${PARQUET_THRIFT_SOURCE_DIR}/parquet_types.cpp"
183180
platform.cc
184181
printer.cc
@@ -307,7 +304,6 @@ add_arrow_lib(parquet
307304

308305
if(WIN32 AND NOT (ARROW_TEST_LINKAGE STREQUAL "static"))
309306
add_library(parquet_test_support STATIC
310-
"${PARQUET_THRIFT_SOURCE_DIR}/parquet_constants.cpp"
311307
"${PARQUET_THRIFT_SOURCE_DIR}/parquet_types.cpp")
312308
target_link_libraries(parquet_test_support thrift::thrift)
313309
list(PREPEND PARQUET_TEST_LINK_LIBS parquet_test_support)

dev/release/rat_exclude_files.txt

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,6 @@ cpp/build-support/iwyu/*
2525
cpp/cmake_modules/FindPythonLibsNew.cmake
2626
cpp/examples/parquet/parquet-arrow/cmake_modules/FindArrow.cmake
2727
cpp/src/parquet/.parquetcppversion
28-
cpp/src/generated/parquet_constants.cpp
29-
cpp/src/generated/parquet_constants.h
3028
cpp/src/generated/parquet_types.cpp
3129
cpp/src/generated/parquet_types.h
3230
cpp/src/generated/substrait/*

0 commit comments

Comments
 (0)