Fix shift included size

AntoinePrv · AntoinePrv · commit a7e4cd94b4e0 · 2025-11-18T15:51:13.000+01:00
diff --git a/cpp/src/arrow/util/bpacking_simd_impl_internal.h b/cpp/src/arrow/util/bpacking_simd_impl_internal.h
@@ -405,7 +405,7 @@ auto left_shift_no_overflow(const xsimd::batch<Int, Arch>& batch,
     if constexpr (sizeof(Int) == sizeof(uint16_t)) {
       return _mm_mullo_epi16(batch, kMults.as_batch());
     }
-    if constexpr (sizeof(Int) == sizeof(uint16_t)) {
+    if constexpr (sizeof(Int) == sizeof(uint32_t)) {
       // TODO that is latency 10 so maybe it is not worth it
       return _mm_mullo_epi32(batch, kMults.as_batch());
     }
@@ -446,7 +446,7 @@ auto right_shift_by_excess(const xsimd::batch<Int, Arch>& batch,
       return xsimd::batch<Int, Arch>(_mm_mullo_epi16(batch, kMults.as_batch())) >>
              kMaxRightShift;
     }
-    if constexpr (sizeof(Int) == sizeof(uint16_t)) {
+    if constexpr (sizeof(Int) == sizeof(uint32_t)) {
       // TODO that is latency 10 so maybe it is not worth it
       return xsimd::batch<Int, Arch>(_mm_mullo_epi32(batch, kMults.as_batch())) >>
              kMaxRightShift;

Original file line number	Diff line number	Diff line change
`@@ -405,7 +405,7 @@ auto left_shift_no_overflow(const xsimd::batch<Int, Arch>& batch,`
`405`	`405`	`if constexpr (sizeof(Int) == sizeof(uint16_t)) {`
`406`	`406`	`return _mm_mullo_epi16(batch, kMults.as_batch());`
`407`	`407`	`}`
`408`		`- if constexpr (sizeof(Int) == sizeof(uint16_t)) {`
	`408`	`+ if constexpr (sizeof(Int) == sizeof(uint32_t)) {`
`409`	`409`	`// TODO that is latency 10 so maybe it is not worth it`
`410`	`410`	`return _mm_mullo_epi32(batch, kMults.as_batch());`
`411`	`411`	`}`
`@@ -446,7 +446,7 @@ auto right_shift_by_excess(const xsimd::batch<Int, Arch>& batch,`
`446`	`446`	`return xsimd::batch<Int, Arch>(_mm_mullo_epi16(batch, kMults.as_batch())) >>`
`447`	`447`	`kMaxRightShift;`
`448`	`448`	`}`
`449`		`- if constexpr (sizeof(Int) == sizeof(uint16_t)) {`
	`449`	`+ if constexpr (sizeof(Int) == sizeof(uint32_t)) {`
`450`	`450`	`// TODO that is latency 10 so maybe it is not worth it`
`451`	`451`	`return xsimd::batch<Int, Arch>(_mm_mullo_epi32(batch, kMults.as_batch())) >>`
`452`	`452`	`kMaxRightShift;`