Move initialization logic out of header

Author: adamreeve

cpp/src/parquet/properties.cc

@@ -67,4 +67,48 @@ std::shared_ptr<ArrowWriterProperties> default_arrow_writer_properties() {
   return default_writer_properties;
 }
 
+void WriterProperties::Builder::CopyColumnSpecificProperties(
+    const WriterProperties& properties) {
+  for (const auto& [col_path, col_props] : properties.column_properties_) {
+    if (col_props.statistics_enabled() !=
+        default_column_properties_.statistics_enabled()) {
+      if (col_props.statistics_enabled()) {
+        this->enable_statistics(col_path);
+      } else {
+        this->disable_statistics(col_path);
+      }
+    }
+
+    if (col_props.dictionary_enabled() !=
+        default_column_properties_.dictionary_enabled()) {
+      if (col_props.dictionary_enabled()) {
+        this->enable_dictionary(col_path);
+      } else {
+        this->disable_dictionary(col_path);
+      }
+    }
+
+    if (col_props.page_index_enabled() !=
+        default_column_properties_.page_index_enabled()) {
+      if (col_props.page_index_enabled()) {
+        this->enable_write_page_index(col_path);
+      } else {
+        this->disable_write_page_index(col_path);
+      }
+    }
+
+    if (col_props.compression() != default_column_properties_.compression()) {
+      this->compression(col_path, col_props.compression());
+    }
+
+    if (col_props.compression_level() != default_column_properties_.compression_level()) {
+      this->compression_level(col_path, col_props.compression_level());
+    }
+
+    if (col_props.encoding() != default_column_properties_.encoding()) {
+      this->encoding(col_path, col_props.encoding());
+    }
+  }
+}
+
 }  // namespace parquet

cpp/src/parquet/properties.h

@@ -323,47 +323,7 @@ class PARQUET_EXPORT WriterProperties {
               properties.content_defined_chunking_enabled()),
           content_defined_chunking_options_(
               properties.content_defined_chunking_options()) {
-      for (const auto& [col_path, col_props] : properties.column_properties_) {
-        if (col_props.statistics_enabled() !=
-            default_column_properties_.statistics_enabled()) {
-          if (col_props.statistics_enabled()) {
-            this->enable_statistics(col_path);
-          } else {
-            this->disable_statistics(col_path);
-          }
-        }
-
-        if (col_props.dictionary_enabled() !=
-            default_column_properties_.dictionary_enabled()) {
-          if (col_props.dictionary_enabled()) {
-            this->enable_dictionary(col_path);
-          } else {
-            this->disable_dictionary(col_path);
-          }
-        }
-
-        if (col_props.page_index_enabled() !=
-            default_column_properties_.page_index_enabled()) {
-          if (col_props.page_index_enabled()) {
-            this->enable_write_page_index(col_path);
-          } else {
-            this->disable_write_page_index(col_path);
-          }
-        }
-
-        if (col_props.compression() != default_column_properties_.compression()) {
-          this->compression(col_path, col_props.compression());
-        }
-
-        if (col_props.compression_level() !=
-            default_column_properties_.compression_level()) {
-          this->compression_level(col_path, col_props.compression_level());
-        }
-
-        if (col_props.encoding() != default_column_properties_.encoding()) {
-          this->encoding(col_path, col_props.encoding());
-        }
-      }
+      CopyColumnSpecificProperties(properties);
     }
 
     /// \brief EXPERIMENTAL: Use content-defined page chunking for all columns.
@@ -826,6 +786,8 @@ class PARQUET_EXPORT WriterProperties {
     }
 
    private:
+    void CopyColumnSpecificProperties(const WriterProperties& properties);
+
     MemoryPool* pool_;
     int64_t dictionary_pagesize_limit_;
     int64_t write_batch_size_;