@@ -1768,7 +1768,6 @@ struct CaseWhenFunctor<Type, enable_if_base_binary<Type>> {
17681768 using offset_type = typename Type::offset_type;
17691769 using BuilderType = typename TypeTraits<Type>::BuilderType;
17701770 static Status Exec (KernelContext* ctx, const ExecSpan& batch, ExecResult* out) {
1771- // / TODO(wesm): should this be a DCHECK? Or checked elsewhere
17721771 if (batch[0 ].null_count () > 0 ) {
17731772 return Status::Invalid (" cond struct must not have outer nulls" );
17741773 }
@@ -1816,7 +1815,6 @@ struct CaseWhenFunctor<Type, enable_if_var_size_list<Type>> {
18161815 using offset_type = typename Type::offset_type;
18171816 using BuilderType = typename TypeTraits<Type>::BuilderType;
18181817 static Status Exec (KernelContext* ctx, const ExecSpan& batch, ExecResult* out) {
1819- // / TODO(wesm): should this be a DCHECK? Or checked elsewhere
18201818 if (batch[0 ].null_count () > 0 ) {
18211819 return Status::Invalid (" cond struct must not have outer nulls" );
18221820 }
@@ -1858,7 +1856,6 @@ struct CaseWhenFunctor<Type, enable_if_list_view<Type>> {
18581856 using offset_type = typename Type::offset_type;
18591857 using BuilderType = typename TypeTraits<Type>::BuilderType;
18601858 static Status Exec (KernelContext* ctx, const ExecSpan& batch, ExecResult* out) {
1861- // / TODO(wesm): should this be a DCHECK? Or checked elsewhere
18621859 if (batch[0 ].null_count () > 0 ) {
18631860 return Status::Invalid (" cond struct must not have outer nulls" );
18641861 }
@@ -1900,7 +1897,6 @@ Status ReserveNoData(ArrayBuilder*) { return Status::OK(); }
19001897template <>
19011898struct CaseWhenFunctor <MapType> {
19021899 static Status Exec (KernelContext* ctx, const ExecSpan& batch, ExecResult* out) {
1903- // / TODO(wesm): should this be a DCHECK? Or checked elsewhere
19041900 if (batch[0 ].null_count () > 0 ) {
19051901 return Status::Invalid (" cond struct must not have outer nulls" );
19061902 }
@@ -1918,7 +1914,6 @@ struct CaseWhenFunctor<MapType> {
19181914template <>
19191915struct CaseWhenFunctor <StructType> {
19201916 static Status Exec (KernelContext* ctx, const ExecSpan& batch, ExecResult* out) {
1921- // / TODO(wesm): should this be a DCHECK? Or checked elsewhere
19221917 if (batch[0 ].null_count () > 0 ) {
19231918 return Status::Invalid (" cond struct must not have outer nulls" );
19241919 }
@@ -1936,7 +1931,6 @@ struct CaseWhenFunctor<StructType> {
19361931template <>
19371932struct CaseWhenFunctor <FixedSizeListType> {
19381933 static Status Exec (KernelContext* ctx, const ExecSpan& batch, ExecResult* out) {
1939- // / TODO(wesm): should this be a DCHECK? Or checked elsewhere
19401934 if (batch[0 ].null_count () > 0 ) {
19411935 return Status::Invalid (" cond struct must not have outer nulls" );
19421936 }
@@ -1964,7 +1958,6 @@ struct CaseWhenFunctor<FixedSizeListType> {
19641958template <typename Type>
19651959struct CaseWhenFunctor <Type, enable_if_union<Type>> {
19661960 static Status Exec (KernelContext* ctx, const ExecSpan& batch, ExecResult* out) {
1967- // / TODO(wesm): should this be a DCHECK? Or checked elsewhere
19681961 if (batch[0 ].null_count () > 0 ) {
19691962 return Status::Invalid (" cond struct must not have outer nulls" );
19701963 }
@@ -1978,7 +1971,6 @@ struct CaseWhenFunctor<Type, enable_if_union<Type>> {
19781971template <>
19791972struct CaseWhenFunctor <DictionaryType> {
19801973 static Status Exec (KernelContext* ctx, const ExecSpan& batch, ExecResult* out) {
1981- // / TODO(wesm): should this be a DCHECK? Or checked elsewhere
19821974 if (batch[0 ].null_count () > 0 ) {
19831975 return Status::Invalid (" cond struct must not have outer nulls" );
19841976 }
@@ -2410,7 +2402,6 @@ struct CoalesceFunctor<Type, enable_if_base_binary<Type>> {
24102402 }
24112403
24122404 static Status ExecArray (KernelContext* ctx, const ExecSpan& batch, ExecResult* out) {
2413- // TODO: do this without ToArrayData()?
24142405 return ExecVarWidthCoalesceImpl (
24152406 ctx, batch, out,
24162407 [&](ArrayBuilder* builder) {
0 commit comments