Skip to content

Commit b4901bf

Browse files
committed
Use generator expression for OPENTELEMETRY_PROTOBUF_LIBRARY and OPENTELEMETRY_PROTOC_EXECUTABLE so it works with FetchContent targets too
1 parent 1840e6e commit b4901bf

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

cpp/cmake_modules/ThirdpartyToolchain.cmake

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4288,10 +4288,8 @@ macro(build_opentelemetry)
42884288

42894289
get_target_property(OPENTELEMETRY_PROTOBUF_INCLUDE_DIR ${ARROW_PROTOBUF_LIBPROTOBUF}
42904290
INTERFACE_INCLUDE_DIRECTORIES)
4291-
get_target_property(OPENTELEMETRY_PROTOBUF_LIBRARY ${ARROW_PROTOBUF_LIBPROTOBUF}
4292-
IMPORTED_LOCATION)
4293-
get_target_property(OPENTELEMETRY_PROTOC_EXECUTABLE ${ARROW_PROTOBUF_PROTOC}
4294-
IMPORTED_LOCATION)
4291+
set(OPENTELEMETRY_PROTOBUF_LIBRARY "$<TARGET_FILE:${ARROW_PROTOBUF_LIBPROTOBUF}>")
4292+
set(OPENTELEMETRY_PROTOC_EXECUTABLE "$<TARGET_FILE:${ARROW_PROTOBUF_PROTOC}>")
42954293
list(APPEND
42964294
OPENTELEMETRY_CMAKE_ARGS
42974295
-DWITH_OTLP_HTTP=ON

0 commit comments

Comments
 (0)