Skip to content

Commit be16412

Browse files
committed
win compat
1 parent b202264 commit be16412

File tree

2 files changed

+11
-10
lines changed

2 files changed

+11
-10
lines changed

ci/scripts/python_build.bat

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@ py -0p
3232

3333
@REM Setup MSVC environment
3434

35-
call "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Auxiliary\Build\vcvarsall.bat" x64
3635
@echo on
3736

3837
echo "=== CCACHE Stats before build ==="
@@ -134,6 +133,6 @@ pushd %SOURCE_DIR%\python
134133
%PYTHON_CMD% -m pip install -r requirements-build.txt || exit /B 1
135134

136135
@REM Build PyArrow
137-
%PYTHON_CMD% -m pip install --no-deps --no-build-isolation -vv . || exit /B 1
136+
%PYTHON_CMD% -m pip install --no-deps --no-build-isolation -vv --vsenv . || exit /B 1
138137

139138
popd

python/pyarrow/meson.build

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -80,23 +80,24 @@ pyarrow_srcs += files('src/arrow/python/filesystem.cc')
8080

8181
subdir('src/arrow/python')
8282

83+
arrow_compute_dep = dependency(
84+
'arrow-compute',
85+
'ArrowCompute',
86+
modules: ['ArrowCompute::arrow_compute_shared'],
87+
)
88+
89+
libpyarrow_deps = [arrow_dep, arrow_compute_dep]
90+
8391
cython_modules = {
8492
'lib': {},
85-
'_compute': {},
93+
'_compute': {'dependencies': arrow_compute_dep},
8694
'_csv': {},
8795
'_feather': {},
8896
'_fs': {},
8997
'_json': {},
9098
'_pyarrow_cpp_tests': {},
9199
}
92100

93-
arrow_compute_dep = dependency(
94-
'arrow-compute',
95-
'ArrowCompute',
96-
modules: ['ArrowCompute::arrow_compute_shared'],
97-
)
98-
99-
libpyarrow_deps = [arrow_dep, arrow_compute_dep]
100101

101102
needs_substrait = get_option('substrait').enabled()
102103
needs_dataset = get_option('dataset').enabled() or needs_substrait
@@ -311,6 +312,7 @@ foreach key, val : cython_modules
311312
override_options: ['cython_language=cpp'],
312313
install: true,
313314
subdir: 'pyarrow',
315+
gnu_symbol_visibility: 'inlineshidden',
314316
)
315317

316318
install_data(cython_mod_name, install_dir: py.get_install_dir() / 'pyarrow')

0 commit comments

Comments
 (0)