Add typechecking for Windows

Author: rok

.github/workflows/python.yml

@@ -242,6 +242,8 @@ jobs:
         run: ci/scripts/python_test.sh $(pwd) $(pwd)/build
       - name: Test annotations
         shell: bash
+        env:
+          PYARROW_TEST_ANNOTATIONS: "ON"
         run: ci/scripts/python_test_type_annotations.sh $(pwd)
 
   windows:
@@ -300,3 +302,7 @@ jobs:
         shell: cmd
         run: |
           call "ci\scripts\python_test.bat" %cd%
+      - name: Test annotations
+        shell: cmd
+        run: |
+          call "ci\scripts\python_test_type_annotations.bat" %cd%\python

ci/scripts/python_test_type_annotations.bat

@@ -0,0 +1,35 @@
+@rem Licensed to the Apache Software Foundation (ASF) under one
+@rem or more contributor license agreements.  See the NOTICE file
+@rem distributed with this work for additional information
+@rem regarding copyright ownership.  The ASF licenses this file
+@rem to you under the Apache License, Version 2.0 (the
+@rem "License"); you may not use this file except in compliance
+@rem with the License.  You may obtain a copy of the License at
+@rem
+@rem   http://www.apache.org/licenses/LICENSE-2.0
+@rem
+@rem Unless required by applicable law or agreed to in writing,
+@rem software distributed under the License is distributed on an
+@rem "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+@rem KIND, either express or implied.  See the License for the
+@rem specific language governing permissions and limitations
+@rem under the License.
+
+@echo on
+
+set PYARROW_DIR=%1
+
+echo Annotation testing on Windows ...
+
+@REM Install library stubs
+%PYTHON_CMD% -m pip install pandas-stubs scipy-stubs sphinx types-cffi types-psutil types-requests types-python-dateutil || exit /B 1
+
+@REM Install type checkers
+%PYTHON_CMD% -m pip install mypy pyright ty || exit /B 1
+
+@REM Run type checkers
+pushd PYARROW_DIR
+
+mypy
+pyright
+ty check

ci/scripts/python_test_type_annotations.sh

@@ -20,25 +20,17 @@
 set -ex
 
 if [ "${PYARROW_TEST_ANNOTATIONS}" == "ON" ]; then
-
-  pyarrow_dir=${1}
-
   # Install library stubs
   pip install pandas-stubs scipy-stubs sphinx types-cffi types-psutil types-requests types-python-dateutil
 
   # Install type checkers
   pip install mypy pyright ty
 
-  # TODO: pandas shouldn't be necessary, fix the stubs
-  # Install other dependencies
-  pip install pandas
-
   # Run type checkers
-  pushd "${pyarrow_dir}"
+  pushd "${1}"
   mypy
   pyright
   ty check;
-
 else
   echo "Skipping type annotation tests";
 fi