Skip to content

Commit c2fb0e3

Browse files
authored
GH-46623: [C++][Compute] Fix the failure of large memory test in arrow-compute-row-test (#46635)
### Rationale for this change In #45336 we refined the row table buffer accessors and enforced the validation on who can call the `var_length_rows()` method. However a legacy test `CompareColumnsToRowsOver4GBFixedLength` is leveraging this accessor to assert this buffer being null. ### What changes are included in this PR? We can just check if the row table is fixed length. ### Are these changes tested? Yes. ### Are there any user-facing changes? None. * GitHub Issue: #46623 Authored-by: Rossi Sun <[email protected]> Signed-off-by: Antoine Pitrou <[email protected]>
1 parent 4539dfb commit c2fb0e3

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

cpp/src/arrow/compute/row/compare_test.cc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -386,8 +386,8 @@ TEST(KeyCompare, LARGE_MEMORY_TEST(CompareColumnsToRowsOver4GBFixedLength)) {
386386
RowTableImpl row_table_right,
387387
RepeatRowTableUntil(MakeRowTableFromExecBatch(batch_left).ValueUnsafe(),
388388
num_rows_row_table));
389-
// The row table must not contain a third buffer.
390-
ASSERT_EQ(row_table_right.var_length_rows(), NULLPTR);
389+
// The row table must be fixed length.
390+
ASSERT_TRUE(row_table_right.metadata().is_fixed_length);
391391
// The row data must be greater than 4GB.
392392
ASSERT_GT(row_table_right.buffer_size(1), k4GB);
393393

0 commit comments

Comments
 (0)