Skip to content

Commit c8baf8a

Browse files
authored
GH-47225: [C++] Remove Skyhook (#47262)
### Rationale for this change We decided to move Skyhook to its own repository here: https://lists.apache.org/thread/f5ndxf0o6v4wbzgoy6nsrj4xkn34f380 We've created https://github.com/apache/arrow-skyhook and extract Skyhook related commits to the repository. ### What changes are included in this PR? Remove Skyhook from the main repository ### Are these changes tested? CI is validated. ### Are there any user-facing changes? Yes, Skyhook is removed from the main repository. * GitHub Issue: #47225 Authored-by: Raúl Cumplido <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
1 parent 066b216 commit c8baf8a

29 files changed

+1
-2142
lines changed

ci/scripts/cpp_build.sh

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -221,7 +221,6 @@ else
221221
-DARROW_RUNTIME_SIMD_LEVEL=${ARROW_RUNTIME_SIMD_LEVEL:-MAX} \
222222
-DARROW_S3=${ARROW_S3:-OFF} \
223223
-DARROW_SIMD_LEVEL=${ARROW_SIMD_LEVEL:-DEFAULT} \
224-
-DARROW_SKYHOOK=${ARROW_SKYHOOK:-OFF} \
225224
-DARROW_SUBSTRAIT=${ARROW_SUBSTRAIT:-OFF} \
226225
-DARROW_TEST_LINKAGE=${ARROW_TEST_LINKAGE:-shared} \
227226
-DARROW_TEST_MEMCHECK=${ARROW_TEST_MEMCHECK:-OFF} \

ci/scripts/generate_dataset.py

Lines changed: 0 additions & 47 deletions
This file was deleted.

ci/scripts/integration_skyhook.sh

Lines changed: 0 additions & 141 deletions
This file was deleted.

cpp/CMakeLists.txt

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -706,10 +706,6 @@ if(ARROW_GANDIVA)
706706
add_subdirectory(src/gandiva)
707707
endif()
708708

709-
if(ARROW_SKYHOOK)
710-
add_subdirectory(src/skyhook)
711-
endif()
712-
713709
if(ARROW_BUILD_EXAMPLES)
714710
add_custom_target(runexample ctest -L example)
715711
add_subdirectory(examples/arrow)

cpp/CMakePresets.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -179,7 +179,6 @@
179179
"ARROW_BUILD_EXAMPLES": "ON",
180180
"ARROW_BUILD_UTILITIES": "ON",
181181
"ARROW_FLIGHT_SQL_ODBC": "ON",
182-
"ARROW_SKYHOOK": "ON",
183182
"ARROW_TENSORFLOW": "ON",
184183
"PARQUET_BUILD_EXAMPLES": "ON",
185184
"PARQUET_BUILD_EXECUTABLES": "ON"

cpp/build-support/update-flatbuffers.sh

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,3 @@ FILES=($(find $FORMAT_DIR -name '*.fbs'))
3434
FILES+=("$SOURCE_DIR/arrow/ipc/feather.fbs")
3535

3636
$FLATC -o "$OUT_DIR" "${FILES[@]}"
37-
38-
# Skyhook flatbuffers
39-
$FLATC -o "$SOURCE_DIR/skyhook/protocol" \
40-
"$SOURCE_DIR/skyhook/protocol/ScanRequest.fbs"

cpp/cmake_modules/DefineOptions.cmake

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -407,15 +407,6 @@ takes precedence over ccache if a storage backend is configured" ON)
407407
DEPENDS
408408
ARROW_S3)
409409

410-
define_option(ARROW_SKYHOOK
411-
"Build the Skyhook libraries"
412-
OFF
413-
DEPENDS
414-
ARROW_DATASET
415-
ARROW_PARQUET
416-
ARROW_WITH_LZ4
417-
ARROW_WITH_SNAPPY)
418-
419410
define_option(ARROW_SUBSTRAIT
420411
"Build the Arrow Substrait Consumer Module"
421412
OFF

cpp/examples/arrow/CMakeLists.txt

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -188,19 +188,6 @@ if(ARROW_PARQUET AND ARROW_DATASET)
188188
endif()
189189

190190
add_arrow_example(udf_example)
191-
192-
if(ARROW_SKYHOOK)
193-
if(ARROW_BUILD_SHARED)
194-
list(APPEND DATASET_EXAMPLES_LINK_LIBS arrow_skyhook_shared)
195-
else()
196-
list(APPEND DATASET_EXAMPLES_LINK_LIBS arrow_skyhook_static)
197-
endif()
198-
199-
add_arrow_example(dataset_skyhook_scan_example EXTRA_LINK_LIBS
200-
${DATASET_EXAMPLES_LINK_LIBS})
201-
add_dependencies(dataset-skyhook-scan-example parquet)
202-
endif()
203-
204191
endif()
205192

206193
if(ARROW_GANDIVA)

0 commit comments

Comments
 (0)