Change map to use std::string

std::string_view doesn't work well with std::map because once the std::string_view object is out of scope, the key is no longer valid. The map then has undefined behavior.

Enabling transparent comparing only helps with the `find` function, not inserts. For inserts we still need to use a std::string constructor.

Ran ODBC tests on MSVC locally and they passed.

Author: alinaliBQ

cpp/src/arrow/flight/sql/odbc/odbc_impl/config/configuration.cc

@@ -171,7 +171,7 @@ void Configuration::Set(std::string_view key, const std::wstring& wvalue) {
 void Configuration::Set(std::string_view key, const std::string& value) {
   const std::string copy = boost::trim_copy(value);
   if (!copy.empty()) {
-    this->properties_[key] = value;
+    this->properties_[std::string(key)] = value;
   }
 }
 

cpp/src/arrow/flight/sql/odbc/odbc_impl/flight_sql_connection_test.cc

@@ -65,10 +65,10 @@ TEST(MetadataSettingsTest, StringColumnLengthTest) {
   const int32_t expected_string_column_length = 100000;
 
   const Connection::ConnPropertyMap properties = {
-      {FlightSqlConnection::HOST, "localhost"},        // expect not used
-      {FlightSqlConnection::PORT, "32010"},            // expect not used
-      {FlightSqlConnection::USE_ENCRYPTION, "false"},  // expect not used
-      {FlightSqlConnection::STRING_COLUMN_LENGTH,
+      {std::string(FlightSqlConnection::HOST), "localhost"},        // expect not used
+      {std::string(FlightSqlConnection::PORT), "32010"},            // expect not used
+      {std::string(FlightSqlConnection::USE_ENCRYPTION), "false"},  // expect not used
+      {std::string(FlightSqlConnection::STRING_COLUMN_LENGTH),
        std::to_string(expected_string_column_length)},
   };
 
@@ -86,10 +86,10 @@ TEST(MetadataSettingsTest, UseWideCharTest) {
   connection.SetClosed(false);
 
   const Connection::ConnPropertyMap properties1 = {
-      {FlightSqlConnection::USE_WIDE_CHAR, "true"},
+      {std::string(FlightSqlConnection::USE_WIDE_CHAR), "true"},
   };
   const Connection::ConnPropertyMap properties2 = {
-      {FlightSqlConnection::USE_WIDE_CHAR, "false"},
+      {std::string(FlightSqlConnection::USE_WIDE_CHAR), "false"},
   };
 
   EXPECT_EQ(true, connection.GetUseWideChar(properties1));
@@ -101,9 +101,9 @@ TEST(MetadataSettingsTest, UseWideCharTest) {
 TEST(BuildLocationTests, ForTcp) {
   std::vector<std::string_view> missing_attr;
   Connection::ConnPropertyMap properties = {
-      {FlightSqlConnection::HOST, "localhost"},
-      {FlightSqlConnection::PORT, "32010"},
-      {FlightSqlConnection::USE_ENCRYPTION, "false"},
+      {std::string(FlightSqlConnection::HOST), "localhost"},
+      {std::string(FlightSqlConnection::PORT), "32010"},
+      {std::string(FlightSqlConnection::USE_ENCRYPTION), "false"},
   };
 
   const std::shared_ptr<FlightSqlSslConfig>& ssl_config =
@@ -113,8 +113,8 @@ TEST(BuildLocationTests, ForTcp) {
       FlightSqlConnection::BuildLocation(properties, missing_attr, ssl_config);
   const Location& actual_location2 = FlightSqlConnection::BuildLocation(
       {
-          {FlightSqlConnection::HOST, "localhost"},
-          {FlightSqlConnection::PORT, "32011"},
+          {std::string(FlightSqlConnection::HOST), "localhost"},
+          {std::string(FlightSqlConnection::PORT), "32011"},
       },
       missing_attr, ssl_config);
 
@@ -127,9 +127,9 @@ TEST(BuildLocationTests, ForTcp) {
 TEST(BuildLocationTests, ForTls) {
   std::vector<std::string_view> missing_attr;
   Connection::ConnPropertyMap properties = {
-      {FlightSqlConnection::HOST, "localhost"},
-      {FlightSqlConnection::PORT, "32010"},
-      {FlightSqlConnection::USE_ENCRYPTION, "1"},
+      {std::string(FlightSqlConnection::HOST), "localhost"},
+      {std::string(FlightSqlConnection::PORT), "32010"},
+      {std::string(FlightSqlConnection::USE_ENCRYPTION), "1"},
   };
 
   const std::shared_ptr<FlightSqlSslConfig>& ssl_config =
@@ -139,9 +139,9 @@ TEST(BuildLocationTests, ForTls) {
       FlightSqlConnection::BuildLocation(properties, missing_attr, ssl_config);
 
   Connection::ConnPropertyMap second_properties = {
-      {FlightSqlConnection::HOST, "localhost"},
-      {FlightSqlConnection::PORT, "32011"},
-      {FlightSqlConnection::USE_ENCRYPTION, "1"},
+      {std::string(FlightSqlConnection::HOST), "localhost"},
+      {std::string(FlightSqlConnection::PORT), "32011"},
+      {std::string(FlightSqlConnection::USE_ENCRYPTION), "1"},
   };
 
   const std::shared_ptr<FlightSqlSslConfig>& second_ssl_config =

cpp/src/arrow/flight/sql/odbc/odbc_impl/main.cc

@@ -202,11 +202,11 @@ int main() {
       driver.CreateConnection(arrow::flight::sql::odbc::OdbcVersion::V_3);
 
   Connection::ConnPropertyMap properties = {
-      {FlightSqlConnection::HOST, "automaster.apache"},
-      {FlightSqlConnection::PORT, "32010"},
-      {FlightSqlConnection::USER, "apache"},
-      {FlightSqlConnection::PASSWORD, "apache123"},
-      {FlightSqlConnection::USE_ENCRYPTION, "false"},
+      {std::string(FlightSqlConnection::HOST), "automaster.apache"},
+      {std::string(FlightSqlConnection::PORT), "32010"},
+      {std::string(FlightSqlConnection::USER), "apache"},
+      {std::string(FlightSqlConnection::PASSWORD), "apache123"},
+      {std::string(FlightSqlConnection::USE_ENCRYPTION), "false"},
   };
   std::vector<std::string_view> missing_attr;
   connection->Connect(properties, missing_attr);

cpp/src/arrow/flight/sql/odbc/odbc_impl/spi/connection.h

@@ -40,7 +40,7 @@ struct CaseInsensitiveComparator {
 };
 
 // PropertyMap is case-insensitive for keys.
-typedef std::map<std::string_view, std::string, CaseInsensitiveComparator> PropertyMap;
+typedef std::map<std::string, std::string, CaseInsensitiveComparator> PropertyMap;
 
 class Statement;