Add constand for unspecified stop

This also overrides the stop getter and setters in Ruby so that nil can be used instead.

Author: stenlarsson

c_glib/arrow-glib/compute.cpp

@@ -7527,7 +7527,7 @@ garrow_list_slice_options_set_property(GObject *object,
   case PROP_LIST_SLICE_OPTIONS_STOP:
     {
       gint64 stop_value = g_value_get_int64(value);
-      if (stop_value == -1) {
+      if (stop_value == GARROW_LIST_SLICE_OPTIONS_STOP_UNSPECIFIED) {
         options->stop = std::nullopt;
       } else {
         options->stop = stop_value;
@@ -7579,7 +7579,7 @@ garrow_list_slice_options_get_property(GObject *object,
     if (options->stop.has_value()) {
       g_value_set_int64(value, options->stop.value());
     } else {
-      g_value_set_int64(value, -1); // Sentinel value for "not set"
+      g_value_set_int64(value, GARROW_LIST_SLICE_OPTIONS_STOP_UNSPECIFIED);
     }
     break;
   case PROP_LIST_SLICE_OPTIONS_STEP:
@@ -7641,18 +7641,20 @@ garrow_list_slice_options_class_init(GArrowListSliceOptionsClass *klass)
   /**
    * GArrowListSliceOptions:stop:
    *
-   * Optional stop of list slicing. If not set (value is -1), then slice to end.
+   * Optional stop of list slicing. If not set (value is
+   * %GARROW_LIST_SLICE_OPTIONS_STOP_UNSPECIFIED), then slice to end.
    *
    * Since: 23.0.0
    */
-  spec = g_param_spec_int64(
-    "stop",
-    "Stop",
-    "Optional stop of list slicing. If not set (value is -1), then slice to end",
-    -1, // Use -1 as sentinel for "not set"
-    G_MAXINT64,
-    -1, // Default to -1 (not set)
-    static_cast<GParamFlags>(G_PARAM_READWRITE));
+  spec =
+    g_param_spec_int64("stop",
+                       "Stop",
+                       "Optional stop of list slicing. If not set (value is "
+                       "GARROW_LIST_SLICE_OPTIONS_STOP_UNSPECIFIED), then slice to end",
+                       GARROW_LIST_SLICE_OPTIONS_STOP_UNSPECIFIED,
+                       G_MAXINT64,
+                       GARROW_LIST_SLICE_OPTIONS_STOP_UNSPECIFIED,
+                       static_cast<GParamFlags>(G_PARAM_READWRITE));
   g_object_class_install_property(gobject_class, PROP_LIST_SLICE_OPTIONS_STOP, spec);
 
   /**
@@ -8586,7 +8588,7 @@ garrow_list_flatten_options_get_raw(GArrowListFlattenOptions *options)
 GArrowListSliceOptions *
 garrow_list_slice_options_new_raw(const arrow::compute::ListSliceOptions *arrow_options)
 {
-  gint64 stop_value = -1;
+  gint64 stop_value = GARROW_LIST_SLICE_OPTIONS_STOP_UNSPECIFIED;
   if (arrow_options->stop.has_value()) {
     stop_value = arrow_options->stop.value();
   }

c_glib/arrow-glib/compute.h

@@ -1359,7 +1359,18 @@ typedef enum {
   GARROW_LIST_SLICE_RETURN_FIXED_SIZE_LIST_TRUE,
 } GArrowListSliceReturnFixedSizeList;
 
-#define GARROW_TYPE_LIST_SLICE_OPTIONS (garrow_list_slice_options_get_type())
+/**
+ * GARROW_LIST_SLICE_OPTIONS_STOP_UNSPECIFIED:
+ *
+ * Sentinel value for the stop property in #GArrowListSliceOptions indicating
+ * that the stop value is not set. When this value is used, the slice will
+ * continue to the end of the list.
+ *
+ * Since: 23.0.0
+ */
+#define GARROW_LIST_SLICE_OPTIONS_STOP_UNSPECIFIED -1
+
+#define GARROW_TYPE_LIST_SLICE_OPTIONS             (garrow_list_slice_options_get_type())
 GARROW_AVAILABLE_IN_23_0
 G_DECLARE_DERIVABLE_TYPE(GArrowListSliceOptions,
                          garrow_list_slice_options,

c_glib/test/test-list-slice-options.rb

@@ -29,13 +29,11 @@ def test_start_property
   end
 
   def test_stop_property
-    # Default is -1 (not set)
-    assert_equal(-1, @options.stop)
+    assert_equal(Arrow::LIST_SLICE_OPTIONS_STOP_UNSPECIFIED, @options.stop)
     @options.stop = 5
     assert_equal(5, @options.stop)
-    # Setting to -1 means "not set"
-    @options.stop = -1
-    assert_equal(-1, @options.stop)
+    @options.stop = Arrow::LIST_SLICE_OPTIONS_STOP_UNSPECIFIED
+    assert_equal(LIST_SLICE_OPTIONS_STOP_UNSPECIFIED, @options.stop)
   end
 
   def test_step_property
@@ -76,7 +74,7 @@ def test_list_slice_function_without_stop
                                              [[1, 2, 3], [4, 5]])),
     ]
     @options.start = 1
-    @options.stop = -1
+    @options.stop = Arrow::LIST_SLICE_OPTIONS_STOP_UNSPECIFIED
     list_slice_function = Arrow::Function.find("list_slice")
     result = list_slice_function.execute(args, @options).value
     assert_equal(build_list_array(Arrow::Int8DataType.new, [[2, 3], [5]]),

ruby/red-arrow/lib/arrow/libraries.rb

@@ -79,6 +79,7 @@
 require_relative "large-list-data-type"
 require_relative "list-array-builder"
 require_relative "list-data-type"
+require_relative "list-slice-options"
 require_relative "map-array"
 require_relative "map-array-builder"
 require_relative "map-data-type"

ruby/red-arrow/lib/arrow/list-slice-options.rb

@@ -0,0 +1,33 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+module Arrow
+  class ListSliceOptions
+    alias_method :stop_raw, :stop
+    private :stop_raw
+
+    # Optional stop of list slicing. If set to nil, then slice to end.
+    def stop
+      stop_raw == LIST_SLICE_OPTIONS_STOP_UNSPECIFIED ? nil : stop_raw
+    end
+
+    # Optional stop of list slicing. If set to nil, then slice to end.
+    def stop=(stop)
+      set_property(:stop, stop.nil? ? LIST_SLICE_OPTIONS_STOP_UNSPECIFIED : stop)
+    end
+  end
+end

ruby/red-arrow/test/test-list-slice-options.rb

@@ -0,0 +1,42 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+class TestListSliceOptions < Test::Unit::TestCase
+  def setup
+    @options = Arrow::ListSliceOptions.new
+  end
+
+  def test_stop_property
+    assert_equal(nil, @options.stop)
+    @options.stop = 5
+    assert_equal(5, @options.stop)
+    @options.stop = nil
+    assert_equal(nil, @options.stop)
+  end
+
+  def test_list_slice_function_without_stop
+    args = [
+      Arrow::ArrayDatum.new(Arrow::ListArray.new([:list, :int8], [[1, 2, 3], [4, 5]])),
+    ]
+    @options.start = 1
+    @options.stop = nil
+    list_slice_function = Arrow::Function.find("list_slice")
+    result = list_slice_function.execute(args, @options).value
+    assert_equal(Arrow::ListArray.new([:list, :int8], [[2, 3], [5]]),
+                 result)
+  end
+end