Add /EHsc flag

alinaliBQ · alinaliBQ · commit d71c0ce7b17a · 2025-11-05T15:24:48.000-08:00
* Add back `CMAKE_CXX_STANDARD: "17"`
diff --git a/.github/workflows/cpp_windows.yml b/.github/workflows/cpp_windows.yml
@@ -64,6 +64,7 @@ jobs:
       ARROW_WITH_ZLIB: ON
       ARROW_WITH_ZSTD: ON
       BOOST_SOURCE: BUNDLED
+      CMAKE_CXX_STANDARD: "17"
       CMAKE_GENERATOR: Ninja
       CMAKE_INSTALL_PREFIX: /usr
       CMAKE_UNITY_BUILD: ON
diff --git a/cpp/cmake_modules/SetupCxxFlags.cmake b/cpp/cmake_modules/SetupCxxFlags.cmake
@@ -186,6 +186,7 @@ if(WIN32)
       #
       # ARROW-2986: Without /EHsc we get C4530 warning
       set(CXX_COMMON_FLAGS "/W3 /EHsc")
+      string(APPEND CMAKE_CXX_FLAGS " /EHsc")
     endif()
 
     # Disable C5105 (macro expansion producing 'defined' has undefined

Original file line number	Diff line number	Diff line change
`@@ -186,6 +186,7 @@ if(WIN32)`
`186`	`186`	`#`
`187`	`187`	`# ARROW-2986: Without /EHsc we get C4530 warning`
`188`	`188`	`set(CXX_COMMON_FLAGS "/W3 /EHsc")`
	`189`	`+ string(APPEND CMAKE_CXX_FLAGS " /EHsc")`
`189`	`190`	`endif()`
`190`	`191`
`191`	`192`	`# Disable C5105 (macro expansion producing 'defined' has undefined`