Commit ddd25d1
authored
### Rationale for this change
Testing with [Numba-CUDA](https://github.com/NVIDIA/numba-cuda) which uses the [NVIDIA CUDA Python bindings](https://github.com/NVIDIA/cuda-python) by default identified that PyArrow Numba interop has an incompatibility with Numba / Numba-CUDA using the NVIDIA bindings. See Issue #47128.
### What changes are included in this PR?
The fix is to get device pointer values from their `device_pointer_value` property, which is consistent across the ctypes and NVIDIA bindings in Numba.
I also attempted to update the CI config to install Numba-CUDA. I think some of the comments in `docker-compose.yml` were a bit out of sync with changes to it, so I also updated comments that appeared to be relevant to reflect what I had to run locally. I could have got the CI changes all wrong - happy to change these, as they're not really the critical part of this PR.
Fixes #47128.
### Are these changes tested?
Yes, by the existing `test_cuda_numba_interop.py` and the CI changes in this PR.
### Are there any user-facing changes?
No.
* GitHub Issue: #47128
Authored-by: Graham Markall <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
1 parent cd8e677 commit ddd25d1
File tree
5 files changed
+30
-10
lines changed- ci
- docker
- scripts
- python/pyarrow
5 files changed
+30
-10
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
67 | 67 | | |
68 | 68 | | |
69 | 69 | | |
| 70 | + | |
70 | 71 | | |
71 | 72 | | |
72 | 73 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
32 | 32 | | |
33 | 33 | | |
34 | 34 | | |
| 35 | + | |
35 | 36 | | |
36 | 37 | | |
37 | | - | |
| 38 | + | |
38 | 39 | | |
39 | 40 | | |
40 | 41 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
22 | | - | |
23 | | - | |
| 22 | + | |
| 23 | + | |
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
| |||
41 | 41 | | |
42 | 42 | | |
43 | 43 | | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
560 | 560 | | |
561 | 561 | | |
562 | 562 | | |
563 | | - | |
564 | | - | |
| 563 | + | |
| 564 | + | |
565 | 565 | | |
566 | 566 | | |
| 567 | + | |
567 | 568 | | |
568 | 569 | | |
569 | 570 | | |
| |||
946 | 947 | | |
947 | 948 | | |
948 | 949 | | |
949 | | - | |
950 | | - | |
951 | | - | |
| 950 | + | |
| 951 | + | |
| 952 | + | |
952 | 953 | | |
953 | 954 | | |
954 | 955 | | |
955 | 956 | | |
| 957 | + | |
| 958 | + | |
956 | 959 | | |
957 | 960 | | |
958 | 961 | | |
| |||
962 | 965 | | |
963 | 966 | | |
964 | 967 | | |
| 968 | + | |
965 | 969 | | |
966 | 970 | | |
967 | 971 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
451 | 451 | | |
452 | 452 | | |
453 | 453 | | |
454 | | - | |
| 454 | + | |
455 | 455 | | |
456 | | - | |
| 456 | + | |
457 | 457 | | |
458 | 458 | | |
459 | 459 | | |
| |||
0 commit comments