lint

Author: ArnavBalyan

cpp/cmake_modules/ThirdpartyToolchain.cmake

@@ -73,7 +73,9 @@ set(ARROW_THIRDPARTY_DEPENDENCIES
     ZLIB
     zstd)
 
-set(fsst_SOURCE "BUNDLED" CACHE STRING "Source of fsst dependency")
+set(fsst_SOURCE
+    "BUNDLED"
+    CACHE STRING "Source of fsst dependency")
 
 # For backward compatibility. We use "BOOST_SOURCE" if "Boost_SOURCE"
 # isn't specified and "BOOST_SOURCE" is specified.
@@ -2613,16 +2615,22 @@ endif()
 function(build_fsst)
   message(STATUS "Configuring vendored FSST sources")
 
-  set(ARROW_FSST_INCLUDE_DIR "${ARROW_SOURCE_DIR}/thirdparty/fsst" PARENT_SCOPE)
+  set(ARROW_FSST_INCLUDE_DIR
+      "${ARROW_SOURCE_DIR}/thirdparty/fsst"
+      PARENT_SCOPE)
   set(ARROW_FSST_SOURCES
       "${ARROW_SOURCE_DIR}/thirdparty/fsst/libfsst.cpp;${ARROW_SOURCE_DIR}/thirdparty/fsst/fsst_avx512.cpp"
       PARENT_SCOPE)
-  set(FSST_VENDORED TRUE PARENT_SCOPE)
+  set(FSST_VENDORED
+      TRUE
+      PARENT_SCOPE)
 endfunction()
 
 if(ARROW_WITH_FSST)
   if(NOT fsst_SOURCE STREQUAL "BUNDLED")
-    message(FATAL_ERROR "FSST must currently be built from source. Set fsst_SOURCE=BUNDLED.")
+    message(
+      FATAL_ERROR
+        "FSST must currently be built from source. Set fsst_SOURCE=BUNDLED.")
   endif()
   resolve_dependency(fsst IS_RUNTIME_DEPENDENCY FALSE)
 endif()

cpp/src/parquet/CMakeLists.txt

@@ -206,13 +206,19 @@ if(DEFINED ARROW_FSST_INCLUDE_DIR)
   list(APPEND PARQUET_TEST_EXTRA_INCLUDES ${ARROW_FSST_INCLUDE_DIR})
 endif()
 if(DEFINED ARROW_FSST_SOURCES)
-  set_property(SOURCE ${ARROW_FSST_SOURCES} APPEND PROPERTY COMPILE_OPTIONS
-               "$<$<OR:$<CXX_COMPILER_ID:Clang>,$<CXX_COMPILER_ID:AppleClang>>:-Wno-error=shorten-64-to-32;-Wno-shorten-64-to-32>"
-               "$<$<OR:$<CXX_COMPILER_ID:Clang>,$<CXX_COMPILER_ID:AppleClang>,$<CXX_COMPILER_ID:GNU>>:-Wno-error=missing-declarations;-Wno-missing-declarations>"
-               "$<$<CXX_COMPILER_ID:MSVC>:/wd4244>")
-  set_property(SOURCE ${ARROW_FSST_SOURCES} APPEND PROPERTY COMPILE_OPTIONS
-               "$<$<AND:$<PLATFORM_ID:Windows>,$<NOT:$<CXX_COMPILER_ID:MSVC>>>:-include>"
-               "$<$<AND:$<PLATFORM_ID:Windows>,$<NOT:$<CXX_COMPILER_ID:MSVC>>>:${CMAKE_CURRENT_SOURCE_DIR}/fsst_compat.h>")
+  set_property(
+    SOURCE ${ARROW_FSST_SOURCES}
+    APPEND
+    PROPERTY COMPILE_OPTIONS
+             "$<$<OR:$<CXX_COMPILER_ID:Clang>,$<CXX_COMPILER_ID:AppleClang>>:-Wno-error=shorten-64-to-32;-Wno-shorten-64-to-32>"
+             "$<$<OR:$<CXX_COMPILER_ID:Clang>,$<CXX_COMPILER_ID:AppleClang>,$<CXX_COMPILER_ID:GNU>>:-Wno-error=missing-declarations;-Wno-missing-declarations>"
+             "$<$<CXX_COMPILER_ID:MSVC>:/wd4244>")
+  set_property(
+    SOURCE ${ARROW_FSST_SOURCES}
+    APPEND
+    PROPERTY COMPILE_OPTIONS
+             "$<$<AND:$<PLATFORM_ID:Windows>,$<NOT:$<CXX_COMPILER_ID:MSVC>>>:-include>"
+             "$<$<AND:$<PLATFORM_ID:Windows>,$<NOT:$<CXX_COMPILER_ID:MSVC>>>:${CMAKE_CURRENT_SOURCE_DIR}/fsst_compat.h>")
 endif()
 
 if(ARROW_HAVE_RUNTIME_AVX2)
@@ -333,7 +339,8 @@ add_arrow_lib(parquet
 if(PARQUET_PRIVATE_INCLUDE_DIRS)
   foreach(_parquet_target parquet_objlib parquet_shared parquet_static)
     if(TARGET ${_parquet_target})
-      target_include_directories(${_parquet_target} PRIVATE ${PARQUET_PRIVATE_INCLUDE_DIRS})
+      target_include_directories(
+        ${_parquet_target} PRIVATE ${PARQUET_PRIVATE_INCLUDE_DIRS})
     endif()
   endforeach()
 endif()

cpp/src/parquet/decoder.cc

@@ -21,6 +21,7 @@
 #include <cstdint>
 #include <cstdlib>
 #include <cstring>
+#include <deque>
 #include <iostream>
 #include <limits>
 #include <memory>
@@ -29,7 +30,6 @@
 #include <type_traits>
 #include <utility>
 #include <vector>
-#include <deque>
 
 #include "arrow/array.h"
 #include "arrow/array/builder_binary.h"

cpp/src/parquet/fsst_compat.h

@@ -21,13 +21,13 @@
 // can be compiled with the compilers Arrow supports.
 
 #if defined(_WIN32) && !defined(_MSC_VER)
-#include <cpuid.h>
+#  include <cpuid.h>
 
 // MinGW does not provide __cpuidex, but FSST only needs the CPUID
 // leaf/sub-leaf variant that __cpuid_count implements.
 static inline void arrow_fsst_cpuidex(int info[4], int function_id, int subfunction_id) {
   __cpuid_count(function_id, subfunction_id, info[0], info[1], info[2], info[3]);
 }
-#define __cpuidex(info, function_id, subfunction_id) \
-  arrow_fsst_cpuidex(info, function_id, subfunction_id)
+#  define __cpuidex(info, function_id, subfunction_id) \
+    arrow_fsst_cpuidex(info, function_id, subfunction_id)
 #endif