Add GitHub issues for TODO comments

* removed TODO comments that were no longer applicable (i.e., comments that seemed that should have been removed)

Author: alinaliBQ

cpp/src/arrow/flight/sql/odbc/CMakeLists.txt

@@ -110,10 +110,10 @@ if(ARROW_FLIGHT_SQL_ODBC_INSTALLER)
   set(CPACK_PACKAGE_NAME ${ODBC_PACKAGE_NAME})
   set(CPACK_PACKAGE_VENDOR ${ODBC_PACKAGE_VENDOR})
   set(CPACK_PACKAGE_DESCRIPTION_SUMMARY "Apache Arrow Flight SQL ODBC Driver")
-  set(CPACK_PACKAGE_CONTACT "#TODO arrow maintainers")
+  set(CPACK_PACKAGE_CONTACT "#GH-47787 TODO arrow maintainers")
 
-  # TODO: set up `flight_sql_odbc_lib` component for macOS Installer
-  # TODO: set up `flight_sql_odbc_lib` component for Linux Installer
+  # GH-47876 TODO: set up `flight_sql_odbc_lib` component for macOS Installer
+  # GH-47877 TODO: set up `flight_sql_odbc_lib` component for Linux Installer
   if(WIN32)
     install(DIRECTORY "${BUILD_OUTPUT_ROOT_DIRECTORY}${CMAKE_BUILD_TYPE}/"
             DESTINATION bin
@@ -156,8 +156,8 @@ if(ARROW_FLIGHT_SQL_ODBC_INSTALLER)
     # Upgrade GUID is required to be unchanged for ODBC installer to upgrade
     set(CPACK_WIX_UPGRADE_GUID "DBF27A18-F8BF-423F-9E3A-957414D52C4B")
   endif()
-  # TODO: create macOS Installer using cpack
-  # TODO: create Linux Installer using cpack
+  # GH-47876 TODO: create macOS Installer using cpack
+  # GH-47877 TODO: create Linux Installer using cpack
 
   # Load CPack after all CPACK* variables are set
   include(CPack)

cpp/src/arrow/flight/sql/odbc/odbc_api.cc

@@ -264,8 +264,7 @@ SQLRETURN SQLGetDiagField(SQLSMALLINT handle_type, SQLHANDLE handle,
                           SQLSMALLINT rec_number, SQLSMALLINT diag_identifier,
                           SQLPOINTER diag_info_ptr, SQLSMALLINT buffer_length,
                           SQLSMALLINT* string_length_ptr) {
-  // TODO: Implement additional fields types
-  // https://github.com/apache/arrow/issues/46573
+  // GH-46573 TODO: Implement additional fields types
   ARROW_LOG(DEBUG) << "SQLGetDiagFieldW called with handle_type: " << handle_type
                    << ", handle: " << handle << ", rec_number: " << rec_number
                    << ", diag_identifier: " << diag_identifier
@@ -345,7 +344,7 @@ SQLRETURN SQLGetDiagField(SQLSMALLINT handle_type, SQLHANDLE handle,
       return SQL_SUCCESS;
     }
 
-    // TODO implement return code function
+    // Driver manager implements SQL_DIAG_RETURNCODE
     case SQL_DIAG_RETURNCODE: {
       return SQL_SUCCESS;
     }
@@ -789,11 +788,10 @@ SQLRETURN SQLDriverConnect(SQLHDBC conn, SQLHWND window_handle,
                    << static_cast<const void*>(out_connection_string_len)
                    << ", driver_completion: " << driver_completion;
 
-  // TODO: Implement FILEDSN and SAVEFILE keywords according to the spec
-  // https://github.com/apache/arrow/issues/46449
+  // GH-46449 TODO: Implement FILEDSN and SAVEFILE keywords according to the spec
 
-  // TODO: Copy connection string properly in SQLDriverConnect according to the
-  // spec https://github.com/apache/arrow/issues/46560
+  // GH-46560 TODO: Copy connection string properly in SQLDriverConnect according to the
+  // spec
 
   using ODBC::ODBCConnection;
 
@@ -810,8 +808,8 @@ SQLRETURN SQLDriverConnect(SQLHDBC conn, SQLHWND window_handle,
 
     std::vector<std::string_view> missing_properties;
 
-    // TODO: Implement SQL_DRIVER_COMPLETE_REQUIRED in SQLDriverConnect according to the
-    // spec https://github.com/apache/arrow/issues/46448
+    // GH-46448 TODO: Implement SQL_DRIVER_COMPLETE_REQUIRED in SQLDriverConnect according
+    // to the spec
 #if defined _WIN32 || defined _WIN64
     // Load the DSN window according to driver_completion
     if (driver_completion == SQL_DRIVER_PROMPT) {

cpp/src/arrow/flight/sql/odbc/odbc_impl/accessors/types.h

@@ -102,7 +102,7 @@ class FlightSqlAccessor : public Accessor {
           throw NullWithoutIndicatorException();
         }
       } else {
-        // TODO: Optimize this by creating different versions of MoveSingleCell
+        // GH-47849 TODO: Optimize this by creating different versions of MoveSingleCell
         // depending on if str_len_buffer is null.
         auto row_status = MoveSingleCell(binding, current_arrow_row, i, value_offset,
                                          update_value_offset, diagnostics);

cpp/src/arrow/flight/sql/odbc/odbc_impl/flight_sql_auth_method.cc

@@ -38,9 +38,8 @@ class NoOpAuthMethod : public FlightSqlAuthMethod {
                     FlightCallOptions& call_options) override {
     // Do nothing
 
-    // TODO: implement NoOpAuthMethod to validate server address.
+    // GH-46733 TODO: implement NoOpAuthMethod to validate server address.
     // Can use NoOpClientAuthHandler.
-    // https://github.com/apache/arrow/issues/46733
   }
 };
 

cpp/src/arrow/flight/sql/odbc/odbc_impl/flight_sql_connection.cc

@@ -339,7 +339,7 @@ Location FlightSqlConnection::BuildLocation(
           ThrowIfNotOK(Location::ForGrpcTls(host_name_info, port).Value(&location));
           return location;
         }
-        // TODO: We should log that we could not convert an IP to hostname here.
+        // GH-47852 TODO: We should log that we could not convert an IP to hostname here.
       }
     } catch (...) {
       // This is expected. The Host attribute can be an IP or name, but make_address will

cpp/src/arrow/flight/sql/odbc/odbc_impl/flight_sql_get_tables_reader.cc

@@ -77,10 +77,9 @@ std::shared_ptr<Schema> GetTablesReader::GetSchema() {
   const arrow::Result<std::shared_ptr<Schema>>& result =
       arrow::ipc::ReadSchema(&dataset_schema_reader, &in_memo);
   if (!result.ok()) {
-    // TODO: Test and build the driver against a server that returns
+    // GH-46561 TODO: Test and build the driver against a server that returns
     // complex types columns with the children
     // types and handle the failure properly
-    // https://github.com/apache/arrow/issues/46561
     return nullptr;
   }
 

cpp/src/arrow/flight/sql/odbc/odbc_impl/flight_sql_result_set_metadata.cc

@@ -157,19 +157,27 @@ size_t FlightSqlResultSetMetadata::GetLength(int column_position) {
 }
 
 std::string FlightSqlResultSetMetadata::GetLiteralPrefix(int column_position) {
-  // TODO: Flight SQL column metadata does not have this, should we add to the spec?
+  // GH-47853 TODO: use `ColumnMetadata` to get literal prefix after Flight SQL protocol
+  // adds support for it
+
+  // Flight SQL column metadata does not have literal prefix, empty string is returned
   return "";
 }
 
 std::string FlightSqlResultSetMetadata::GetLiteralSuffix(int column_position) {
-  // TODO: Flight SQL column metadata does not have this, should we add to the spec?
+  // GH-47853 TODO: use `ColumnMetadata` to get literal suffix after Flight SQL protocol
+  // adds support for it
+
+  // Flight SQL column metadata does not have literal suffix, empty string is returned
   return "";
 }
 
 std::string FlightSqlResultSetMetadata::GetLocalTypeName(int column_position) {
   ColumnMetadata metadata = GetMetadata(schema_->field(column_position - 1));
 
-  // TODO: Is local type name the same as type name?
+  // Local type name is for display purpose only.
+  // Return type name as local type name as Flight SQL protocol doesn't have support for
+  // local type name.
   return metadata.GetTypeName().ValueOrElse([] { return ""; });
 }
 
@@ -192,7 +200,7 @@ size_t FlightSqlResultSetMetadata::GetOctetLength(int column_position) {
 
   // Workaround to get the precision for Decimal and Numeric types, since server doesn't
   // return it currently.
-  // TODO: Use the server precision when its fixed.
+  // GH-47854 TODO: Use the server precision when its fixed.
   std::shared_ptr<DataType> arrow_type = field->type();
   if (arrow_type->id() == Type::DECIMAL128) {
     int32_t precision = util::GetDecimalTypePrecision(arrow_type);
@@ -220,7 +228,6 @@ Updatability FlightSqlResultSetMetadata::GetUpdatable(int column_position) {
 bool FlightSqlResultSetMetadata::IsAutoUnique(int column_position) {
   ColumnMetadata metadata = GetMetadata(schema_->field(column_position - 1));
 
-  // TODO: Is AutoUnique equivalent to AutoIncrement?
   return metadata.GetIsAutoIncrement().ValueOrElse([] { return false; });
 }
 

cpp/src/arrow/flight/sql/odbc/odbc_impl/flight_sql_statement_get_columns.cc

@@ -101,10 +101,9 @@ Result<std::shared_ptr<RecordBatch>> TransformInner(
     const auto& table_name = reader.GetTableName();
     const std::shared_ptr<Schema>& schema = reader.GetSchema();
     if (schema == nullptr) {
-      // TODO: Test and build the driver against a server that returns
+      // GH-46561 TODO: Test and build the driver against a server that returns
       // complex types columns with the children
       // types and handle the failure properly.
-      // https://github.com/apache/arrow/issues/46561
       continue;
     }
     for (int i = 0; i < schema->num_fields(); ++i) {

cpp/src/arrow/flight/sql/odbc/odbc_impl/get_info_cache.cc

@@ -316,8 +316,8 @@ bool GetInfoCache::LoadInfoFromServer() {
               std::string server_name(
                   reinterpret_cast<StringScalar*>(scalar->child_value().get())->view());
 
-              // TODO: Consider creating different properties in GetSqlInfo.
-              // TODO: Investigate if SQL_SERVER_NAME should just be the host
+              // GH-47855 TODO: Consider creating different properties in GetSqlInfo.
+              // GH-47856 TODO: Investigate if SQL_SERVER_NAME should just be the host
               // address as well. In JDBC, FLIGHT_SQL_SERVER_NAME is only used for
               // the DatabaseProductName.
               info_[SQL_SERVER_NAME] = server_name;

cpp/src/arrow/flight/sql/odbc/odbc_impl/json_converter.cc

@@ -221,7 +221,7 @@ class ScalarToJson : public ScalarVisitor {
   }
 
   Status Visit(const DurationScalar& scalar) override {
-    // TODO: Append TimeUnit on conversion
+    // GH-47857 TODO: Append TimeUnit on conversion
     return ConvertScalarToStringAndWrite(scalar, writer_);
   }