Skip to content

Commit eb1a3de

Browse files
committed
New new attempt to fix Windows build
1 parent 3461fab commit eb1a3de

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

cpp/cmake_modules/ThirdpartyToolchain.cmake

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1910,7 +1910,10 @@ function(build_protobuf)
19101910

19111911
set(protobuf_BUILD_TESTS OFF)
19121912
# Always build protobuf as static library to avoid DLL import/export issues
1913-
set(protobuf_BUILD_SHARED_LIBS OFF)
1913+
# Must be CACHE FORCE to override the option() in protobuf's CMakeLists.txt
1914+
set(protobuf_BUILD_SHARED_LIBS
1915+
OFF
1916+
CACHE BOOL "Build protobuf shared libs" FORCE)
19141917
if(MSVC AND NOT ARROW_USE_STATIC_CRT)
19151918
set(protobuf_MSVC_STATIC_RUNTIME OFF)
19161919
endif()

0 commit comments

Comments
 (0)