Commit eda392c
authored
### Rationale for this change
This is the sub issue #44748.
* SC2034: source_dir appears unused. Verify use (or export if used externally).
* SC2086: Double quote to prevent globbing and word splitting.
* SC2155: Declare and assign separately to avoid masking return values.
```
shellcheck ci/scripts/integration_hdfs.sh
In ci/scripts/integration_hdfs.sh line 22:
source_dir=${1}/cpp
^--------^ SC2034 (warning): source_dir appears unused. Verify use (or export if used externally).
In ci/scripts/integration_hdfs.sh line 25:
export CLASSPATH=$($HADOOP_HOME/bin/hadoop classpath --glob)
^-------^ SC2155 (warning): Declare and assign separately to avoid masking return values.
^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
export CLASSPATH=$("$HADOOP_HOME"/bin/hadoop classpath --glob)
In ci/scripts/integration_hdfs.sh line 45:
pushd ${build_dir}
^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
pushd "${build_dir}"
For more information:
https://www.shellcheck.net/wiki/SC2034 -- source_dir appears unused. Verify...
https://www.shellcheck.net/wiki/SC2155 -- Declare and assign separately to ...
https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...
```
### What changes are included in this PR?
* SC2034: disable shellcheck
* SC2086: Quote variables.
* SC2155: separate variable declaration and export.
### Are these changes tested?
Yes.
### Are there any user-facing changes?
No.
* GitHub Issue: #47125
Authored-by: Hiroyuki Sato <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
1 parent 84e3341 commit eda392c
2 files changed
+5
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
331 | 331 | | |
332 | 332 | | |
333 | 333 | | |
| 334 | + | |
334 | 335 | | |
335 | 336 | | |
336 | 337 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
| 22 | + | |
22 | 23 | | |
23 | 24 | | |
24 | 25 | | |
25 | | - | |
| 26 | + | |
| 27 | + | |
26 | 28 | | |
27 | 29 | | |
28 | 30 | | |
| |||
42 | 44 | | |
43 | 45 | | |
44 | 46 | | |
45 | | - | |
| 47 | + | |
46 | 48 | | |
47 | 49 | | |
48 | 50 | | |
| |||
0 commit comments