Skip to content

Commit fcf3b4b

Browse files
authored
GH-47751: [CI] Fix check for job to ignore on reporting (#47755)
### Rationale for this change It failed notifying on Zulip and the email, see: https://lists.apache.org/thread/12glcwk1jb8lb5x6lw3t2vr6zn9kp66v We basically were ignoring all jobs except the report-ci 😞 ### What changes are included in this PR? The check was wrong, I clearly did not test this properly after the latest change, sorry about that. ### Are these changes tested? I validated locally, without the change: ``` $ archery ci report-chat --dry-run --ignore report-ci --repository apache/arrow 18329667061 *Extra CI GitHub report for <https://github.com/apache/arrow/actions/runs/18329667061|C++ Extra>* :tada: *1 successful jobs* ``` It shows successful because it has now finished, this is not the case when is running on CI, but only a single job which is not expected, it should show 5! with the change: ``` archery ci report-chat --dry-run --ignore report-ci --repository apache/arrow 18329667061 *Extra CI GitHub report for <https://github.com/apache/arrow/actions/runs/18329667061|C++ Extra>* :tada: *5 successful jobs* ``` ### Are there any user-facing changes? No * GitHub Issue: #47751 Authored-by: Raúl Cumplido <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
1 parent ac9d721 commit fcf3b4b

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

dev/archery/archery/ci/core.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ def jobs(self):
7070
# from the reusable workflow this will be report-ci.
7171
# The real job_data['name'] is the display name, like
7272
# "report-extra-cpp / report-ci".
73-
if self.ignore_job in job_data.get('name'):
73+
if self.ignore_job not in job_data.get('name'):
7474
job = Job(job_data)
7575
jobs.append(job)
7676
return jobs

0 commit comments

Comments
 (0)