Skip to content

Commit ff49bc1

Browse files
committed
GH-48433: [C++] Use NDEBUG to fix linkage to abseil libraries
1 parent f8b23be commit ff49bc1

File tree

3 files changed

+7
-1
lines changed

3 files changed

+7
-1
lines changed

ci/docker/conda-cpp.dockerfile

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,8 @@ ENV ARROW_ACERO=ON \
8484
ARROW_WITH_SNAPPY=ON \
8585
ARROW_WITH_ZLIB=ON \
8686
ARROW_WITH_ZSTD=ON \
87+
CFLAGS="-DNDEBUG" \
88+
CXXFLAGS="-DNDEBUG" \
8789
GTest_SOURCE=BUNDLED \
8890
PARQUET_BUILD_EXAMPLES=ON \
8991
PARQUET_BUILD_EXECUTABLES=ON \

ci/docker/conda-python.dockerfile

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,4 +45,6 @@ ENV ARROW_ACERO=ON \
4545
ARROW_JSON=ON \
4646
ARROW_SUBSTRAIT=OFF \
4747
ARROW_TENSORFLOW=ON \
48-
ARROW_USE_GLOG=OFF
48+
ARROW_USE_GLOG=OFF \
49+
CFLAGS="-DNDEBUG" \
50+
CXXFLAGS="-DNDEBUG"

cpp/examples/arrow/rapidjson_row_converter.cc

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -585,6 +585,7 @@ arrow::Status DoRowConversion(int32_t num_rows, int32_t batch_size) {
585585
assert(doc["data"]["deleted"].IsBool());
586586
assert(doc["data"].HasMember("metrics"));
587587
assert(doc["data"]["metrics"].IsArray());
588+
#ifndef NDEBUG
588589
if (doc["data"]["metrics"].Size() > 0) {
589590
auto metric = &doc["data"]["metrics"][0];
590591
assert(metric->IsObject());
@@ -593,6 +594,7 @@ arrow::Status DoRowConversion(int32_t num_rows, int32_t batch_size) {
593594
assert(metric->HasMember("value"));
594595
assert((*metric)["value"].IsInt64());
595596
}
597+
#endif
596598

597599
rapidjson::StringBuffer sb;
598600
rapidjson::Writer<rapidjson::StringBuffer> writer(sb);

0 commit comments

Comments
 (0)