GH-45303: [C++] Refactor ZSTD from ExternalProject to FetchContent#46393
Open
jonkeane wants to merge 2 commits intoapache:mainfrom
Open
GH-45303: [C++] Refactor ZSTD from ExternalProject to FetchContent#46393jonkeane wants to merge 2 commits intoapache:mainfrom
jonkeane wants to merge 2 commits intoapache:mainfrom
Conversation
github-actions
bot
added
Component: C++
awaiting committer review
Member
|
Is there anything left to do here? cc @kou |
kou
reviewed
Jun 13, 2025
Comment on lines
+2745
to
+2747
| # Check which target name is actually created by zstd's CMake | ||
| # zstd on macOS often creates 'zstd_static' despite what the docs say | ||
| if(TARGET zstd_static) |
Member
There was a problem hiding this comment.
Hmm. This is strange...
The target name must be libzstd_static: https://github.com/facebook/zstd/blob/5e6bdf5e3dee6d977ea87b2c50c3bcb14fed3603/build/cmake/lib/CMakeLists.txt#L141
github-actions
bot
added
awaiting changes
kou
reviewed
Jun 13, 2025
| @@ -2690,49 +2690,87 @@ if(ARROW_WITH_LZ4) | |||
| endif() | |||
|
|
|||
| macro(build_zstd) | |||
Member
There was a problem hiding this comment.
We must use function() not macro() here to create a new scope.
Member
Author
|
Sorry, I haven't had the bandwidth to come back to this. Would someone want to take it over for me? If no that's ok — I'll close the PR. |
Member
|
No problem. I'll take it over later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Refactor ZSTD from ExternalProject to FetchContent
Partially resolves #45303
What changes are included in this PR?
Cmake, refactored
Are these changes tested?
Yes
Are there any user-facing changes?
No