-
Notifications
You must be signed in to change notification settings - Fork 4k
GH-48160: [C++][Gandiva] Pass CPU attributes to LLVM #48161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
|
@github-actions crossbow submit -g cpp |
|
Revision: 704804b Submitted crossbow builds: ursacomputing/crossbow @ actions-2b90f7a897 |
kou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
…m generator (dremio#106) Fix crash due to decimal alignement
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 7bc47c0. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
Rationale for this change
The CPU attributes are not passed to the LLVM layer, which means potential optimizations could be missed leading to inefficient code. This feature was lost as part of the refactoring in 83cba25
I also discovered a bug with decimal alignments that was exposed by this change and was only reproducible in our test environment.
What changes are included in this PR?
Pass the CPU attributes to the LLVM code generation, and a unit test.
Fix the 16 bit vs 8 bit decimal alignment problem. This was causing a crash sometimes on certain architectures with certain queries. Added a unit test.
Are these changes tested?
Yes.
Are there any user-facing changes?
No.