ARTEMIS-5852 Simplifying change on FileConfigurationParser

clebertsuconic · clebertsuconic · commit 2d982df0a304 · 2026-02-03T12:58:31.000-05:00
I had a static analyzer considering this change as problematic.
Instead of adding an exception, I decided to simplify the diff
diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/deployers/impl/FileConfigurationParser.java b/artemis-server/src/main/java/org/apache/activemq/artemis/core/deployers/impl/FileConfigurationParser.java
@@ -1674,7 +1674,7 @@ private TransportConfiguration parseAcceptorTransportConfiguration(final Element
       List<TransportConfiguration> configurations = ConfigurationUtils.parseAcceptorURI(name, uri);
       TransportConfiguration transportConfiguration = configurations.get(0);
 
-      Map<String, Object> params = transportConfiguration.getParams();
+      Map<String, Object> params = configurations.get(0).getParams();
 
       if (lockCoordinator != null) {
          transportConfiguration.setLockCoordinator(lockCoordinator);
@@ -1688,7 +1688,7 @@ private TransportConfiguration parseAcceptorTransportConfiguration(final Element
          }
       }
 
-      return transportConfiguration;
+      return configurations.get(0);
    }
 
    private TransportConfiguration parseConnectorTransportConfiguration(final Element e,

Original file line number	Diff line number	Diff line change
`@@ -1674,7 +1674,7 @@ private TransportConfiguration parseAcceptorTransportConfiguration(final Element`
`1674`	`1674`	`List<TransportConfiguration> configurations = ConfigurationUtils.parseAcceptorURI(name, uri);`
`1675`	`1675`	`TransportConfiguration transportConfiguration = configurations.get(0);`
`1676`	`1676`
`1677`		`- Map<String, Object> params = transportConfiguration.getParams();`
	`1677`	`+ Map<String, Object> params = configurations.get(0).getParams();`
`1678`	`1678`
`1679`	`1679`	`if (lockCoordinator != null) {`
`1680`	`1680`	`transportConfiguration.setLockCoordinator(lockCoordinator);`
`@@ -1688,7 +1688,7 @@ private TransportConfiguration parseAcceptorTransportConfiguration(final Element`
`1688`	`1688`	`}`
`1689`	`1689`	`}`
`1690`	`1690`
`1691`		`- return transportConfiguration;`
	`1691`	`+ return configurations.get(0);`
`1692`	`1692`	`}`
`1693`	`1693`
`1694`	`1694`	`private TransportConfiguration parseConnectorTransportConfiguration(final Element e,`