Skip to content

Commit f86f5d8

Browse files
authored
ATLAS-5042: [React UI] Entity detail page - UI alignment, styling, and scroll issues (#359)
1 parent 0b0ec4d commit f86f5d8

File tree

9 files changed

+16
-33
lines changed

9 files changed

+16
-33
lines changed

dashboard/src/components/Forms/FormTextArea.tsx

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -50,15 +50,6 @@ const FormTextArea = ({ data, control }: any) => {
5050
</LightTooltip>
5151
</div>
5252
<div className="w-100">
53-
{/* <TextArea
54-
maxRows={4}
55-
aria-label="maximum height"
56-
placeholder={name}
57-
onChange={onChange}
58-
minRows={2}
59-
className="form-textfield form-textarea-field"
60-
value={value}
61-
/> */}
6253
<textarea
6354
placeholder={name}
6455
onChange={onChange}

dashboard/src/components/commonComponents.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -199,7 +199,7 @@ export const ExtractObject = (props: any) => {
199199
}}
200200
style={{
201201
width: "unset !important",
202-
whiteSpace: "nowrap",
202+
whiteSpace: "normal",
203203
color: deleteIcon ? "#bb5838" : "#4a90e2"
204204
}}
205205
>

dashboard/src/index.scss

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -230,3 +230,7 @@ textarea {
230230
.hide {
231231
display: none !important;
232232
}
233+
234+
textarea::placeholder {
235+
opacity: 0.7;
236+
}

dashboard/src/styles/formFields.scss

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,13 @@
4646
width: 100%;
4747
flex: 1;
4848
margin-bottom: 0.5rem !important;
49+
height: 34px;
50+
border-radius: 3px;
51+
outline: none;
52+
border: 1px solid rgba(0, 0, 0, 0.12);
53+
padding: 6px 12px;
54+
min-height: 34px;
55+
width: 100%;
4956
}
5057

5158
.form-textfield-label {

dashboard/src/styles/propertiesTab.scss

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,4 +57,5 @@
5757

5858
.attribute-value-text > a {
5959
width: 100% !important;
60+
word-break: break-all;
6061
}

dashboard/src/styles/relationshipLineage.scss

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,5 +45,6 @@
4545
.value-text {
4646
a {
4747
width: 100% !important;
48+
word-break: break-all;
4849
}
4950
}

dashboard/src/views/Classification/ClassificationForm.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -328,6 +328,7 @@ const ClassificationForm = ({
328328
) : (
329329
<textarea
330330
{...field}
331+
className="form-textarea-field"
331332
placeholder={"Long Description"}
332333
value={sanitizeHtmlContent(descriptionValue)}
333334
onChange={(e) => {

dashboard/src/views/DetailPage/EntityDetailTabs/PropertiesTab/UserDefinedProperties.tsx

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -353,17 +353,6 @@ const UserDefinedProperties = ({ loading, customAttributes, entity }: any) => {
353353
<>
354354
<div style={{ flex: "1" }}>
355355
<textarea
356-
style={{
357-
height: "34px",
358-
borderRadius: "3px",
359-
outline: "none",
360-
border: "1px solid rgba(0,0,0,0.12)",
361-
padding: "6px 12px",
362-
minHeight: "34px",
363-
width: "100%",
364-
marginTop: "8px !important",
365-
marginBottom: "8px !important"
366-
}}
367356
maxRows={3}
368357
rows={1}
369358
aria-label="maximum height"

dashboard/src/views/Glossary/GlossaryForm.tsx

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -153,20 +153,9 @@ const GlossaryForm = (props: {
153153
/>
154154
</div>
155155
) : (
156-
// <TextArea
157-
// {...field}
158-
// minRows={4}
159-
// placeholder={"Long Description"}
160-
// onChange={(e) => {
161-
// e.stopPropagation();
162-
// const value = e.target.value;
163-
// field.onChange(value);
164-
// setValue("description", value);
165-
// }}
166-
// style={{ width: "100%" }}
167-
// />
168156
<textarea
169157
{...field}
158+
className="form-textarea-field"
170159
placeholder={"Long Description"}
171160
onChange={(e) => {
172161
e.stopPropagation();

0 commit comments

Comments
 (0)