Skip to content

Commit cd87de9

Browse files
committed
[AURON #1907][CI] Fix YAML syntax error and rebase issue
1 parent a603cc0 commit cd87de9

File tree

3 files changed

+32
-52
lines changed

3 files changed

+32
-52
lines changed

.github/workflows/tpcds-reusable.yml

Lines changed: 30 additions & 51 deletions
Original file line numberDiff line numberDiff line change
@@ -88,45 +88,6 @@ env:
8888
WGET_OPTS: "--tries=3 --timeout=30 -c"
8989

9090
jobs:
91-
build-validator:
92-
name: Build TPC-DS Validator
93-
runs-on: ubuntu-24.04
94-
steps:
95-
- name: Cache TPC-DS Validator
96-
uses: actions/cache@v5
97-
id: cache-tpcds-validator
98-
with:
99-
key: tpcds-validator_${{ inputs.scalaver }}
100-
path: target/tpcds-validator_${{ inputs.scalaver }}-0.1.0-SNAPSHOT-with-dependencies.jar
101-
102-
- name: Checkout TPC-DS Validator
103-
uses: actions/checkout@v6
104-
if: steps.cache-tpcds-validator.outputs.cache-hit != 'true'
105-
with:
106-
repository: auron-project/tpcds-validator
107-
108-
- name: Setup Java and Maven cache
109-
uses: actions/setup-java@v5
110-
if: steps.cache-tpcds-validator.outputs.cache-hit != 'true'
111-
with:
112-
distribution: 'adopt-hotspot'
113-
java-version: ${{ inputs.javaver }}
114-
cache: 'maven'
115-
116-
- name: Build TPC-DS Validator
117-
if: steps.cache-tpcds-validator.outputs.cache-hit != 'true'
118-
run: ./build/mvn package -DskipTests -Pscala-${{ inputs.scalaver }}
119-
120-
- name: Upload TPC-DS Validator
121-
uses: actions/upload-artifact@v6
122-
with:
123-
name: >
124-
tpcds-validator-${{ inputs.sparkver }}_${{ inputs.scalaver }}-jdk-${{ inputs.javaver
125-
}}${{ inputs.celebornver && format('-{0}', inputs.celebornver) || ''
126-
}}${{ inputs.unifflever && format('-{0}', inputs.unifflever) || '' }}
127-
path: target/tpcds-validator_${{ inputs.scalaver }}-0.1.0-SNAPSHOT-with-dependencies.jar
128-
overwrite: true
129-
13091
build-auron-jar:
13192
name: Build Auron JAR
13293
runs-on: ubuntu-24.04
@@ -159,8 +120,8 @@ jobs:
159120
clippy
160121

161122
- name: Cargo clippy
123+
# First eliminate unwrap; then enable -D warnings to enforce all default lints.
162124
run: |
163-
# First eliminate unwrap; then enable -D warnings to enforce all default lints.
164125
cargo clippy --all-targets --workspace -- -A warnings -A clippy::all -D clippy::unwrap_used
165126
166127
- name: Cargo test
@@ -223,10 +184,18 @@ jobs:
223184
}}${{ inputs.unifflever && format('-{0}', inputs.unifflever) || '' }}
224185
path: target/auron-${{ inputs.sparkver }}_${{ inputs.scalaver }}-pre-*.jar
225186
overwrite: true
187+
- name: Upload auron maven artifacts (Spark ${{ inputs.sparkver }}, Scala ${{ inputs.scalaver }}, JDK ${{ inputs.javaver }})
188+
uses: actions/upload-artifact@v4
189+
with:
190+
name: auron-artifacts-${{ inputs.sparkver }}_${{ inputs.scalaver }}-jdk-${{ inputs.javaver
191+
}}${{ inputs.celebornver && format('-{0}', inputs.celebornver) || ''
192+
}}${{ inputs.unifflever && format('-{0}', inputs.unifflever) || '' }}
193+
path: ~/.m2/repository/org/apache/auron
194+
if-no-files-found: error
226195

227196
run-tpcds-test:
228197
name: Run TPC-DS test ${{ matrix.query }}
229-
needs: [build-validator, build-auron-jar]
198+
needs: [build-auron-jar]
230199
runs-on: ubuntu-24.04
231200
strategy:
232201
fail-fast: false
@@ -286,13 +255,14 @@ jobs:
286255
}}${{ inputs.celebornver && format('-{0}', inputs.celebornver) || ''
287256
}}${{ inputs.unifflever && format('-{0}', inputs.unifflever) || '' }}
288257
289-
- name: Download TPC-DS Validator JAR
258+
- name: Download auron maven artifacts
290259
uses: actions/download-artifact@v7
291260
with:
292261
name: >
293-
tpcds-validator-${{ inputs.sparkver }}_${{ inputs.scalaver }}-jdk-${{ inputs.javaver
294-
}}${{ inputs.celebornver && format('-{0}', inputs.celebornver) || ''
262+
auron-artifacts-${{ inputs.sparkver }}_${{ inputs.scalaver }}-jdk-${{ inputs.javaver
263+
}}${{ inputs.celebornver && format('-{0}', inputs.celebornver) || ''
295264
}}${{ inputs.unifflever && format('-{0}', inputs.unifflever) || '' }}
265+
path: ~/.m2/repository/org/apache/auron
296266

297267
- name: Checkout TPC-DS Data
298268
uses: actions/checkout@v6
@@ -303,7 +273,10 @@ jobs:
303273
- name: Install Auron JAR
304274
run: |
305275
ls -la
306-
cp auron-*${{ inputs.sparkver }}_${{ inputs.scalaver }}*.jar spark-bin-${{ inputs.sparkver }}_${{ inputs.scalaver }}/jars/
276+
jar=$(ls -1 auron-${{ inputs.sparkver }}_${{ inputs.scalaver }}*.jar | head -n1)
277+
[ -n "$jar" ] || { echo "No jar matched: auron-${{ inputs.sparkver }}_${{ inputs.scalaver }}*.jar"; exit 1; }
278+
echo "AURON_SPARK_JAR=$jar" >> "$GITHUB_ENV"
279+
cp "$jar" spark-bin-${{ inputs.sparkver }}_${{ inputs.scalaver }}/jars/
307280
308281
- name: Setup Java and Maven cache
309282
uses: actions/setup-java@v5
@@ -406,16 +379,22 @@ jobs:
406379
cp uniffle-bin-${{ steps.get-dependency-version.outputs.uniffleversion }}/jars/client/spark3/*.jar spark-bin-${{ inputs.sparkver }}_${{ inputs.scalaver }}/jars/
407380
408381
- name: Run TPC-DS Query ${{ matrix.query }}
382+
env:
383+
RUST_LOG: ERROR
384+
RUST_BACKTRACE: 1
385+
SPARK_VERSION: ${{ inputs.sparkver }}
386+
SCALA_VERSION: ${{ inputs.scalaver }}
387+
SPARK_HOME: spark-bin-${{ inputs.sparkver }}_${{ inputs.scalaver }}
409388
run: |
410389
ls -la
411-
export RUST_LOG=ERROR
412-
export RUST_BACKTRACE=1
413-
export SCALA_VERSION=${{ inputs.scalaver }}
414-
export SPARK_HOME=spark-bin-${{ inputs.sparkver }}_${{ inputs.scalaver }}
415-
dev/run-tpcds-test \
390+
ls -la ~/.m2/repository/org/apache/auron
391+
dev/auron-it/run-it.sh \
416392
${{ inputs.extrasparkconf }} \
393+
--type tpcds \
417394
--data-location dev/tpcds_1g \
418-
--query-filter ${{ matrix.query }}
395+
--query-filter ${{ matrix.query }} \
396+
--result-check \
397+
--plan-check
419398
420399
- name: Upload RSS log
421400
if: ${{ failure() && (inputs.celebornver != '' || inputs.unifflever != '') }}

dev/auron-it/src/main/scala/org/apache/auron/integration/comparison/PlanStabilityChecker.scala

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -118,6 +118,7 @@ class PlanStabilityChecker(
118118
.replaceAll("Arguments: [0-9]+", "Arguments: X")
119119
.replaceAll("Scan parquet ", "Scan parquet")
120120
.replaceAll("Statistics[(A-Za-z0-9=. ,+)]*", "Statistics(X)")
121+
.replaceAll("\\[codegen id : [0-9]+\\]", "[codegen id : X]")
121122

122123
normalizeLocation(argumentsNormalized)
123124
}

dev/auron-it/src/main/scala/org/apache/auron/integration/tpcds/TPCDSSuite.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ class TPCDSSuite(args: SuiteArgs) extends Suite(args) with TPCDSFeatures {
7676
}
7777
}
7878

79-
if (args.enablePlanCheck) {
79+
if (args.enablePlanCheck || args.regenGoldenFiles) {
8080
baseComparisons.foreach(comparisonResult => {
8181
val testResult = auronResults(comparisonResult.queryId)
8282
val planStable = planStabilityChecker.validate(testResult)

0 commit comments

Comments
 (0)