[AURON #1911][clippy] Enable -D warnings and resolve related issues #1922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShreyeshArangath
approved these changes
Jan 18, 2026
Contributor
ShreyeshArangath
left a comment
ShreyeshArangath
left a comment
There was a problem hiding this comment.
LGTM, thanks for fixing this
cxzl25
approved these changes
Jan 19, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enables stricter Clippy linting in the CI pipeline by switching from allowing all warnings to denying all warnings by default, while selectively allowing specific lints that require more extensive refactoring to fix. The PR also resolves many auto-fixable clippy warnings throughout the codebase and annotates existing panic-related code with #[allow(clippy::panic)] attributes.
Changes:
- Configure workspace-level lints with
unwrap_usedandpanicdenied, while temporarily allowing other lints that need gradual refactoring - Update CI and build scripts to use
cargo clippy --all-targets --workspace -- -D warningsinstead of selectively denying onlyunwrap_used - Apply auto-fixes for numerous clippy lints including
needless_borrow,redundant_closure,needless_return,useless_format,uninlined_format_args,manual_range_contains,into_iter_on_ref, and others - Add
#[allow(clippy::panic)]annotations to existing panic-heavy code with comments indicating future refactoring plans
Reviewed changes
Copilot reviewed 56 out of 56 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Cargo.toml | Add workspace-level lint configuration denying unwrap_used and panic, while temporarily allowing other lints |
| dev/mvn-build-helper/build-native.sh | Update clippy command to deny all warnings instead of only unwrap_used |
| .github/workflows/tpcds-reusable.yml | Update clippy command in CI workflow to deny all warnings |
| native-engine/*/Cargo.toml | Add [lints] workspace = true to all sub-crates |
| native-engine/datafusion-ext-plans/src/**/*.rs | Add panic allow annotations to existing panic-heavy code |
| native-engine/datafusion-ext-functions/src/**/*.rs | Apply auto-fixes for clippy lints and add panic annotations |
| native-engine/datafusion-ext-exprs/src/**/*.rs | Apply auto-fixes for needless borrows, redundant closures, and other clippy suggestions |
| native-engine/datafusion-ext-commons/src/**/*.rs | Apply extensive auto-fixes including format strings, redundant references, and test improvements |
| native-engine/auron*/src/**/*.rs | Apply auto-fixes for format strings, needless returns, and const thread_local initialization |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1911
Rationale for this change
What changes are included in this PR?
-D warningsfor Clippy in CI, and setworkspace.lints = truefor all sub-crates to align with unified workspace lint config.cargo clippy --fix.#[allow(clippy::panic)]annotationAre there any user-facing changes?
How was this patch tested?