AXIS2-5948 Add org.apache.axis2.transport.http.HTTPProxyConfiguratorTest

robertlazarski · robertlazarski · commit 2741a1497be2 · 2025-02-14T05:50:58.000-10:00
diff --git a/modules/transport/http/src/main/java/org/apache/axis2/transport/http/impl/httpclient5/HTTPProxyConfigurator.java b/modules/transport/http/src/main/java/org/apache/axis2/transport/http/impl/httpclient5/HTTPProxyConfigurator.java
@@ -152,8 +152,10 @@ public static void configure(MessageContext messageContext, RequestConfig.Builde
             clientContext.setCredentialsProvider(credsProvider);
             credsProvider.setCredentials(new AuthScope(null, -1), proxyCredentials);
 	}
-        HttpHost proxy = new HttpHost(proxyHost, proxyPort);
-        requestConfig.setProxy(proxy);
+	if (proxyHost != null && proxyPort > 0) {
+            HttpHost proxy = new HttpHost(proxyHost, proxyPort);
+            requestConfig.setProxy(proxy);
+        }
     }
 
     private static OMElement getProxyConfigurationElement(Parameter proxySettingsFromAxisConfig)

Original file line number	Diff line number	Diff line change
`@@ -152,8 +152,10 @@ public static void configure(MessageContext messageContext, RequestConfig.Builde`
`152`	`152`	`clientContext.setCredentialsProvider(credsProvider);`
`153`	`153`	`credsProvider.setCredentials(new AuthScope(null, -1), proxyCredentials);`
`154`	`154`	`}`
`155`		`- HttpHost proxy = new HttpHost(proxyHost, proxyPort);`
`156`		`- requestConfig.setProxy(proxy);`
	`155`	`+ if (proxyHost != null && proxyPort > 0) {`
	`156`	`+ HttpHost proxy = new HttpHost(proxyHost, proxyPort);`
	`157`	`+ requestConfig.setProxy(proxy);`
	`158`	`+ }`
`157`	`159`	`}`
`158`	`160`
`159`	`161`	`private static OMElement getProxyConfigurationElement(Parameter proxySettingsFromAxisConfig)`