Skip to content

Commit 0f18f50

Browse files
Chenzo1001Chenzo1001
committed
Fix eslint
1 parent 3d71136 commit 0f18f50

File tree

5 files changed

+67
-69
lines changed

5 files changed

+67
-69
lines changed

‎sdks/python/apache_beam/runners/interactive/extensions/apache-beam-jupyterlab-sidepanel/src/__tests__/clusters/Clusters.test.tsx‎

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -71,9 +71,7 @@ it('renders a data-table', async () => {
7171
}
7272
};
7373
await act(async () => {
74-
root.render(
75-
<Clusters sessionContext={{} as any} ref={clustersRef} />
76-
);
74+
root.render(<Clusters sessionContext={{} as any} ref={clustersRef} />);
7775
});
7876

7977
await act(async () => {

‎sdks/python/apache_beam/runners/interactive/extensions/apache-beam-jupyterlab-sidepanel/src/__tests__/common/HtmlView.test.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ describe('HtmlView', () => {
7777

7878
it(
7979
'only executes incrementally updated Javascript ' +
80-
'as html provider updated',
80+
'as html provider updated',
8181
async () => {
8282
const htmlViewRef: React.RefObject<HtmlView> =
8383
React.createRef<HtmlView>();

‎sdks/python/apache_beam/runners/interactive/extensions/apache-beam-jupyterlab-sidepanel/src/__tests__/inspector/InspectableViewModel.test.ts‎

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -49,8 +49,8 @@ it('builds show query correctly with default values', () => {
4949
inspectableViewModel.queryKernel('pcollection', 'id');
5050
expect(inspectableViewModel.buildShowQuery({} as IShowOptions)).toBe(
5151
"ib.show(ie.current_env().inspector.get_val('id')," +
52-
'include_window_info=False, visualize_data=False, ' +
53-
"duration='inf', n='inf')"
52+
'include_window_info=False, visualize_data=False, ' +
53+
"duration='inf', n='inf')"
5454
);
5555
});
5656

@@ -66,8 +66,8 @@ it('builds show query with given checkbox values correctly', () => {
6666
} as IShowOptions)
6767
).toBe(
6868
"ib.show(ie.current_env().inspector.get_val('id')," +
69-
'include_window_info=True, visualize_data=True, ' +
70-
"duration='inf', n='inf')"
69+
'include_window_info=True, visualize_data=True, ' +
70+
"duration='inf', n='inf')"
7171
);
7272
});
7373

@@ -82,8 +82,8 @@ it('builds show query with string duration', () => {
8282
} as IShowOptions)
8383
).toBe(
8484
"ib.show(ie.current_env().inspector.get_val('id')," +
85-
'include_window_info=False, visualize_data=False, ' +
86-
"duration='60s', n='inf')"
85+
'include_window_info=False, visualize_data=False, ' +
86+
"duration='60s', n='inf')"
8787
);
8888
});
8989

@@ -98,8 +98,8 @@ it('builds show query with negative duration as inf', () => {
9898
} as IShowOptions)
9999
).toBe(
100100
"ib.show(ie.current_env().inspector.get_val('id')," +
101-
'include_window_info=False, visualize_data=False, ' +
102-
"duration='inf', n='inf')"
101+
'include_window_info=False, visualize_data=False, ' +
102+
"duration='inf', n='inf')"
103103
);
104104
});
105105

@@ -114,8 +114,8 @@ it('builds show query with positive duration as int', () => {
114114
} as IShowOptions)
115115
).toBe(
116116
"ib.show(ie.current_env().inspector.get_val('id')," +
117-
'include_window_info=False, visualize_data=False, ' +
118-
"duration=5, n='inf')"
117+
'include_window_info=False, visualize_data=False, ' +
118+
"duration=5, n='inf')"
119119
);
120120
});
121121

@@ -130,8 +130,8 @@ it('builds show query with string n as inf', () => {
130130
} as IShowOptions)
131131
).toBe(
132132
"ib.show(ie.current_env().inspector.get_val('id')," +
133-
'include_window_info=False, visualize_data=False, ' +
134-
"duration='inf', n='inf')"
133+
'include_window_info=False, visualize_data=False, ' +
134+
"duration='inf', n='inf')"
135135
);
136136
});
137137

@@ -146,8 +146,8 @@ it('builds show query with negative n as inf', () => {
146146
} as IShowOptions)
147147
).toBe(
148148
"ib.show(ie.current_env().inspector.get_val('id')," +
149-
'include_window_info=False, visualize_data=False, ' +
150-
"duration='inf', n='inf')"
149+
'include_window_info=False, visualize_data=False, ' +
150+
"duration='inf', n='inf')"
151151
);
152152
});
153153

@@ -162,8 +162,8 @@ it('builds show query with positive n as int', () => {
162162
} as IShowOptions)
163163
).toBe(
164164
"ib.show(ie.current_env().inspector.get_val('id')," +
165-
'include_window_info=False, visualize_data=False, ' +
166-
"duration='inf', n=5)"
165+
'include_window_info=False, visualize_data=False, ' +
166+
"duration='inf', n=5)"
167167
);
168168
});
169169

‎sdks/python/apache_beam/runners/interactive/extensions/apache-beam-jupyterlab-sidepanel/src/__tests__/inspector/Inspectables.test.tsx‎

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -57,23 +57,23 @@ afterEach(async () => {
5757
}
5858
});
5959

60-
it('renders info message about no inspectable when none is available',
61-
async () => {
62-
const inspectablesRef: React.RefObject<Inspectables> =
63-
React.createRef<Inspectables>();
64-
await act(async () => {
65-
root.render(<Inspectables ref={inspectablesRef} />);
66-
const inspectables = inspectablesRef.current;
67-
if (inspectables) {
68-
inspectables.setState({ inspectables: {} });
69-
}
70-
});
71-
const infoElement: Element = container.firstElementChild;
72-
expect(infoElement.tagName).toBe('DIV');
73-
expect(infoElement.textContent).toBe(
74-
'No inspectable pipeline nor pcollection has been defined.'
75-
);
60+
it(`renders info message about no inspectable
61+
when none is available`, async () => {
62+
const inspectablesRef: React.RefObject<Inspectables> =
63+
React.createRef<Inspectables>();
64+
await act(async () => {
65+
root.render(<Inspectables ref={inspectablesRef} />);
66+
const inspectables = inspectablesRef.current;
67+
if (inspectables) {
68+
inspectables.setState({ inspectables: {} });
69+
}
7670
});
71+
const infoElement: Element = container.firstElementChild;
72+
expect(infoElement.tagName).toBe('DIV');
73+
expect(infoElement.textContent).toBe(
74+
'No inspectable pipeline nor pcollection has been defined.'
75+
);
76+
});
7777

7878
it('renders inspectables as a list of collapsible lists', async () => {
7979
const inspectablesRef: React.RefObject<Inspectables> =

‎sdks/python/apache_beam/runners/interactive/extensions/apache-beam-jupyterlab-sidepanel/src/__tests__/kernel/InterruptKernelButton.test.tsx‎

Lines changed: 33 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -53,42 +53,42 @@ afterEach(async () => {
5353
}
5454
});
5555

56-
it('displays a button when the kernel model is not done with execution',
57-
async () => {
58-
let button: InterruptKernelButton;
59-
await act(async () => {
60-
root.render(
61-
<InterruptKernelButton
62-
ref={(node): void => {
63-
button = node;
64-
}}
65-
model={fakeKernelModel as any}
66-
/>
67-
);
68-
});
69-
await act(async () => {
70-
fakeKernelModel.isDone = false;
71-
button?.updateRender();
72-
await new Promise(resolve => setTimeout(resolve, 100));
73-
});
74-
const buttonElement: null | Element = container.firstElementChild;
75-
expect(buttonElement.tagName).toBe('BUTTON');
76-
expect(buttonElement.getAttribute('class')).toContain('mdc-button');
77-
expect(buttonElement.getAttribute('class')).toContain('mdc-button--raised');
78-
const labelElement: Element = buttonElement.children[1];
79-
expect(labelElement.tagName).toBe('SPAN');
80-
expect(labelElement.getAttribute('class')).toContain('mdc-button__label');
81-
expect(labelElement.innerHTML).toBe('stop');
56+
it(`displays a button when the kernel model
57+
is not done with execution`, async () => {
58+
let button: InterruptKernelButton;
59+
await act(async () => {
60+
root.render(
61+
<InterruptKernelButton
62+
ref={(node): void => {
63+
button = node;
64+
}}
65+
model={fakeKernelModel as any}
66+
/>
67+
);
68+
});
69+
await act(async () => {
70+
fakeKernelModel.isDone = false;
71+
button?.updateRender();
72+
await new Promise(resolve => setTimeout(resolve, 100));
8273
});
74+
const buttonElement: null | Element = container.firstElementChild;
75+
expect(buttonElement.tagName).toBe('BUTTON');
76+
expect(buttonElement.getAttribute('class')).toContain('mdc-button');
77+
expect(buttonElement.getAttribute('class')).toContain('mdc-button--raised');
78+
const labelElement: Element = buttonElement.children[1];
79+
expect(labelElement.tagName).toBe('SPAN');
80+
expect(labelElement.getAttribute('class')).toContain('mdc-button__label');
81+
expect(labelElement.innerHTML).toBe('stop');
82+
});
8383

84-
it('renders nothing when the kernel model is done with execution',
85-
async () => {
86-
await act(async () => {
87-
root.render(<InterruptKernelButton model={fakeKernelModel as any} />);
88-
});
89-
const buttonElement: null | Element = container.firstElementChild;
90-
expect(buttonElement).toBe(null);
84+
it(`renders nothing when the kernel
85+
model is done with execution`, async () => {
86+
await act(async () => {
87+
root.render(<InterruptKernelButton model={fakeKernelModel as any} />);
9188
});
89+
const buttonElement: null | Element = container.firstElementChild;
90+
expect(buttonElement).toBe(null);
91+
});
9292

9393
it('interrupts the kernel when clicked', async () => {
9494
let button: InterruptKernelButton;

0 commit comments

Comments
 (0)