@@ -62,15 +62,16 @@ sparkVersions.each { kv ->
6262 // no longer available in SLF4J 2.x. This results in a
6363 // `java.lang.NoClassDefFoundError`.
6464 //
65- // The workaround here provides an SLF4J 1.x binding to resolve the error.
66- // Only `org.apache.logging.log4j:log4j-slf4j-impl` provides a compatible
67- // SLF4J 1.x binding regardless SLF4J upgrade.
68- // Other package from SLF4J (e.g., slf4j-simple, slf4j-reload4j) are
69- // unsuitable because they also get upgraded as new SLF4J version is in use,
70- // and the binding classes are no longer in there.
65+ // The workaround is to provide an SLF4J 1.x binding module out of group
66+ // `org.slf4j` to resolve the issue.
67+ // Module `org.apache.logging.log4j:log4j-slf4j-impl` is an example that
68+ // provides a compatible SLF4J 1.x binding regardless SLF4J upgrade.
69+ // Binding/provider modules under group `org.slf4j` (e.g.,
70+ // slf4j-simple, slf4j-reload4j) get upgraded as a new SLF4J version is in
71+ // use, and therefore do not contain the 1.x binding classes.
7172 //
7273 // Notice that Spark 3.1.x uses `ch.qos.logback:logback-classic` and is
73- // unaffected by this SLF4J upgrade. Spark 3.3.x already uses
74+ // unaffected by the SLF4J upgrade. Spark 3.3.x already uses
7475 // `log4j-slf4j-impl` so it is also unaffected.
7576 if (" $kv . key " >= " 320" && " $kv . key " <= " 324" ) {
7677 " sparkVersion$kv . key " library. java. log4j2_slf4j_impl
0 commit comments