Skip to content

Commit 1dada04

Browse files
committed
[BEAM-10975] Remove capture_output argument in sdk_container_builder (#12942)
1 parent 821fdb6 commit 1dada04

File tree

2 files changed

+3
-6
lines changed

2 files changed

+3
-6
lines changed

sdks/python/apache_beam/runners/dataflow/internal/apiclient_test.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -842,7 +842,7 @@ def test_experiment_use_multiple_sdk_containers(self):
842842

843843
@mock.patch(
844844
'apache_beam.runners.dataflow.internal.apiclient.sys.version_info',
845-
(3, 5))
845+
(3, 8))
846846
def test_get_python_sdk_name(self):
847847
pipeline_options = PipelineOptions([
848848
'--project',
@@ -861,7 +861,7 @@ def test_get_python_sdk_name(self):
861861
1,
862862
FAKE_PIPELINE_URL)
863863
self.assertEqual(
864-
'Apache Beam Python 3.5 SDK', environment._get_python_sdk_name())
864+
'Apache Beam Python 3.8 SDK', environment._get_python_sdk_name())
865865

866866
@mock.patch(
867867
'apache_beam.runners.dataflow.internal.apiclient.sys.version_info',

sdks/python/apache_beam/runners/portability/sdk_container_builder.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -149,7 +149,6 @@ def invoke_docker_build_and_push(self, container_image_name):
149149
_LOGGER.info("Building sdk container, this may take a few minutes...")
150150
now = time.time()
151151
subprocess.run(['docker', 'build', '.', '-t', container_image_name],
152-
capture_output=True,
153152
check=True,
154153
cwd=self._temp_src_dir)
155154
except subprocess.CalledProcessError as err:
@@ -164,9 +163,7 @@ def invoke_docker_build_and_push(self, container_image_name):
164163
if self._docker_registry_push_url:
165164
_LOGGER.info("Pushing prebuilt sdk container...")
166165
try:
167-
subprocess.run(['docker', 'push', container_image_name],
168-
capture_output=True,
169-
check=True)
166+
subprocess.run(['docker', 'push', container_image_name], check=True)
170167
except subprocess.CalledProcessError as err:
171168
raise RuntimeError(
172169
'Failed to push prebuilt sdk container %s, stderr: \n%s' %

0 commit comments

Comments
 (0)