Skip to content

Commit 269c5d5

Browse files
committed
Fixes for github checks
1 parent 83b3d0d commit 269c5d5

File tree

5 files changed

+10
-8
lines changed

5 files changed

+10
-8
lines changed

runners/core-java/src/test/java/org/apache/beam/runners/core/metrics/BoundedTrieNodeTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -807,7 +807,7 @@ public void testBoundedTrieNodeToString() {
807807
public void testEmptyTrie() {
808808
BoundedTrieData trie = new BoundedTrieData();
809809
assertEquals(0, trie.size());
810-
assertTrue(trie.extractResult().result().isEmpty());
810+
assertTrue(trie.extractResult().getResult().isEmpty());
811811
}
812812

813813
@Test
@@ -879,7 +879,7 @@ public void testClear() {
879879
trie.add(ImmutableList.of("a", "b"));
880880
trie.clear();
881881
assertEquals(0, trie.size());
882-
assertTrue(trie.extractResult().result().isEmpty());
882+
assertTrue(trie.extractResult().getResult().isEmpty());
883883
}
884884

885885
@Test
@@ -1005,7 +1005,7 @@ public void testAddEmptyPath() {
10051005
BoundedTrieData trie = new BoundedTrieData();
10061006
trie.add(Collections.emptyList());
10071007
assertEquals(1, trie.size());
1008-
assertTrue(trie.extractResult().result().contains(ImmutableList.of("false")));
1008+
assertTrue(trie.extractResult().getResult().contains(ImmutableList.of("false")));
10091009
}
10101010

10111011
@Test

runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowMetrics.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -214,7 +214,7 @@ private BoundedTrieResult getBoundedTrieValue(MetricUpdate metricUpdate) {
214214
}
215215
BoundedTrie bTrie = (BoundedTrie) metricUpdate.get(BOUNDED_TRIE);
216216
BoundedTrieData trieData = BoundedTrieData.fromProto(bTrie);
217-
return BoundedTrieResult.create(trieData.extractResult().result());
217+
return BoundedTrieResult.create(trieData.extractResult().getResult());
218218
}
219219

220220
private DistributionResult getDistributionValue(MetricUpdate metricUpdate) {

runners/portability/java/src/main/java/org/apache/beam/runners/portability/PortableMetrics.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -192,7 +192,7 @@ private static MetricResult<BoundedTrieResult> convertBoundedTrieMonitoringInfoT
192192
MetricName.named(labelsMap.get(NAMESPACE_LABEL), labelsMap.get(METRIC_NAME_LABEL)));
193193

194194
BoundedTrieData data = decodeBoundedTrie(monitoringInfo.getPayload());
195-
BoundedTrieResult result = BoundedTrieResult.create(data.extractResult().result());
195+
BoundedTrieResult result = BoundedTrieResult.create(data.extractResult().getResult());
196196
return MetricResult.create(key, false, result);
197197
}
198198

runners/portability/java/src/test/java/org/apache/beam/runners/portability/PortableRunnerTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,7 @@ public void extractsMetrics() throws Exception {
138138
metricQueryResults.getStringSets().iterator().next().getAttempted().getStringSet(),
139139
is(STRING_SET_VALUE));
140140
assertThat(
141-
metricQueryResults.getBoundedTries().iterator().next().getAttempted().result(),
141+
metricQueryResults.getBoundedTries().iterator().next().getAttempted().getResult(),
142142
is(ImmutableSet.of(ImmutableList.of("ab", String.valueOf(false)))));
143143
}
144144

sdks/java/core/src/main/java/org/apache/beam/sdk/metrics/Metrics.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -161,14 +161,16 @@ public static StringSet stringSet(Class<?> namespace, String name) {
161161
}
162162

163163
/**
164-
* Create a metric that accumulates and reports set of unique string values bounded to a max limit
164+
* Create a metric that accumulates and reports set of unique string values bounded to a max
165+
* limit.
165166
*/
166167
public static BoundedTrie boundedTrie(Class<?> namespace, String name) {
167168
return new DelegatingBoundedTrie(MetricName.named(namespace, name));
168169
}
169170

170171
/**
171-
* Create a metric that accumulates and reports set of unique string values bounded to a max limit
172+
* Create a metric that accumulates and reports set of unique string values bounded to a max
173+
* limit.
172174
*/
173175
public static BoundedTrie boundedTrie(String namespace, String name) {
174176
return new DelegatingBoundedTrie(MetricName.named(namespace, name));

0 commit comments

Comments
 (0)