Skip to content

Commit 3ffeb79

Browse files
committed
Change MovingAvg's class and method visibility
1 parent f4194cb commit 3ffeb79

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

sdks/java/io/kafka/jmh/src/main/java/org/apache/beam/sdk/io/kafka/jmh/KafkaIOUtilsBenchmark.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919

2020
import java.util.Random;
2121
import java.util.concurrent.TimeUnit;
22+
import org.apache.beam.sdk.io.kafka.KafkaIOUtils;
2223
import org.openjdk.jmh.annotations.Benchmark;
2324
import org.openjdk.jmh.annotations.BenchmarkMode;
2425
import org.openjdk.jmh.annotations.Group;

sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaIOUtils.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -186,15 +186,15 @@ protected long incrementAndGetNumUpdates() {
186186
* Sanity of visibility is only useful when the writer thread changes since avg is the only field that can be shared between multiple concurrent threads.
187187
*/
188188
@SuppressFBWarnings("UUF_UNUSED_FIELD")
189-
static class MovingAvg extends MovingAvgFields {
189+
public static final class MovingAvg extends MovingAvgFields {
190190
byte p100, p101, p102, p103, p104, p105, p106, p107;
191191
byte p110, p111, p112, p113, p114, p115, p116, p117;
192192
byte p120, p121, p122, p123, p124, p125, p126, p127;
193193
byte p130, p131, p132, p133, p134, p135, p136, p137;
194194
byte p140, p141, p142, p143, p144, p145, p146, p147;
195195
byte p150, p151, p152, p153, p154, p155, p156, p157;
196196

197-
void update(final double quantity) {
197+
public void update(final double quantity) {
198198
final double prevAvg = getAvg(); // volatile load (acquire)
199199

200200
final long nextNumUpdates = incrementAndGetNumUpdates(); // normal load/store
@@ -203,7 +203,7 @@ void update(final double quantity) {
203203
setAvg(nextAvg); // ordered store (release)
204204
}
205205

206-
double get() {
206+
public double get() {
207207
return getAvg(); // volatile load (acquire)
208208
}
209209
}

0 commit comments

Comments
 (0)