Skip to content

Commit 49c851b

Browse files
authored
address comments.
1 parent 5659767 commit 49c851b

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

sdks/python/apache_beam/runners/worker/channel_factory.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,10 @@
2323

2424
class GRPCChannelFactory(grpc.StreamStreamClientInterceptor):
2525
DEFAULT_OPTIONS = [
26-
# keep 20 seconds for now. This is needed for other options to work.
27-
("grpc.keepalive_time_ms", 20000),
28-
# keep 5 minutes for now.
29-
("grpc.keepalive_timeout_ms", 300000),
26+
# Setting keepalive_time_ms is needed for other options to work.
27+
("grpc.keepalive_time_ms", 20_000),
28+
# Default: 20s. Increasing to 5 min.
29+
("grpc.keepalive_timeout_ms", 300_000),
3030
# Default: 2, set to 0 to allow unlimited pings without data
3131
("grpc.http2.max_pings_without_data", 0),
3232
# Default: False, set to True to allow keepalive pings when no calls

0 commit comments

Comments
 (0)